From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B00CA9EAF for ; Thu, 24 Oct 2019 10:01:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3999205F4 for ; Thu, 24 Oct 2019 10:01:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393146AbfJXKBP (ORCPT ); Thu, 24 Oct 2019 06:01:15 -0400 Received: from correo.us.es ([193.147.175.20]:53270 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732286AbfJXKBP (ORCPT ); Thu, 24 Oct 2019 06:01:15 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 4AB684A2BA6 for ; Thu, 24 Oct 2019 12:01:10 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3A7FAB8004 for ; Thu, 24 Oct 2019 12:01:10 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 2FF13B7FFB; Thu, 24 Oct 2019 12:01:10 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 446C3202B7; Thu, 24 Oct 2019 12:01:08 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 24 Oct 2019 12:01:08 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 1E8E542EE38E; Thu, 24 Oct 2019 12:01:08 +0200 (CEST) Date: Thu, 24 Oct 2019 12:01:10 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Phil Sutter , netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH] nft: Use ARRAY_SIZE() macro in nft_strerror() Message-ID: <20191024100110.hn65z2s66ktznymw@salvia> References: <20191018155114.7423-1-phil@nwl.cc> <20191023112024.gd4dqe6qqv46hufe@salvia> <20191023112311.qrglbzhqad4vfqvo@salvia> <20191023121627.GM26123@orbyte.nwl.cc> <20191023204149.vushra6ipmjqqd7c@salvia> <20191024084503.GF17858@orbyte.nwl.cc> <20191024092903.sqvoxwwuflk2h4cn@salvia> <20191024095101.GQ26123@orbyte.nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191024095101.GQ26123@orbyte.nwl.cc> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Oct 24, 2019 at 11:51:01AM +0200, Phil Sutter wrote: > Hey, > > On Thu, Oct 24, 2019 at 11:29:03AM +0200, Pablo Neira Ayuso wrote: > [...] > > If gcc is already checking for this. Warning should be fine. > > > > Regarding -Werror, we would at least need to keep the autogenerated C > > code by bison away from it. > > In nftables there is libparser_la_CFLAGS which holds quite some > exclusions already and could be used to pass -Wno-error as well. (Maybe > a good idea to add this regardless of whether we set -Werror by default > or not.) > > > IIRC I enabled this in conntrack-tools long time ago, and I started > > getting reports on it breaking compilation with new gcc versions that > > were actually spewing new warnings. That was stopping users to install > > latest, probably -Werror is too agressive? > > Yes, I wasn't completely serious. Breaking users' builds for things they > may not be in control of is not the best idea. We could instead add a > configure option to enable strict mode, but checking for warnings is > something I usually do so probably not that important after all. Indeed. So let's leave things as is then.