From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5866CA9EC3 for ; Thu, 31 Oct 2019 12:12:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0C4B2080F for ; Thu, 31 Oct 2019 12:12:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726765AbfJaMMg (ORCPT ); Thu, 31 Oct 2019 08:12:36 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:47096 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726540AbfJaMMg (ORCPT ); Thu, 31 Oct 2019 08:12:36 -0400 Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.91) (envelope-from ) id 1iQ9Ja-0003lv-EE; Thu, 31 Oct 2019 13:12:34 +0100 Date: Thu, 31 Oct 2019 13:12:34 +0100 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org, Florian Westphal Subject: Re: [libnftnl PATCH 1/2] libnftnl.map: Export nftnl_{obj,flowtable}_set_data() Message-ID: <20191031121234.GB8531@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org, Florian Westphal References: <20191030174948.12493-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030174948.12493-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi, On Wed, Oct 30, 2019 at 06:49:47PM +0100, Phil Sutter wrote: > In order to deprecate nftnl_{obj,flowtable}_set() functions, these must > to be made available. In case you wonder why current nftables sources don't compile, it's because I had this one applied when pushing 909e297ed430c ("mnl: Replace use of untyped nftnl data setters") so I didn't notice the missing dependency. Quick review of at least this patch is therefore highly appreciated. Sorry, Phil