netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] doc: Drop incorrect requirement for nft configs
Date: Wed, 6 Nov 2019 21:50:52 +0100	[thread overview]
Message-ID: <20191106205052.GV15063@orbyte.nwl.cc> (raw)
In-Reply-To: <20191106202720.xzyeytcaouyoo2kg@salvia>

On Wed, Nov 06, 2019 at 09:27:20PM +0100, Pablo Neira Ayuso wrote:
> On Wed, Nov 06, 2019 at 09:25:57PM +0100, Pablo Neira Ayuso wrote:
> > On Wed, Nov 06, 2019 at 03:19:53PM +0100, Phil Sutter wrote:
> > > On Wed, Nov 06, 2019 at 12:47:24PM +0100, Pablo Neira Ayuso wrote:
> > > > On Tue, Nov 05, 2019 at 02:14:39PM +0100, Phil Sutter wrote:
> > > > > The shebang is not needed in files to be used with --file parameter.
> > > > > 
> > > > > Signed-off-by: Phil Sutter <phil@nwl.cc>
> > > > 
> > > > Right, this is actually handled as a comment right now, not as an
> > > > indication of what binary the user would like to use.
> > > > 
> > > > It should be possible to implement the shebang for nft if you think
> > > > this is useful.
> > > 
> > > Well, it works already? If I make a config having the shebang
> > > executable, I can execute it directly. It's just not needed when passed
> > > to 'nft -f'. And in that use-case, I don't see a point in interpreting
> > > it, the user already chose which binary to use by calling it. :)
> > 
> > Indeed, forget this. Thanks.
> 
> BTW, it would be good to remove this from the example files in the tree.

I'll send a patch, thanks!

      reply	other threads:[~2019-11-06 20:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 13:14 [nft PATCH] doc: Drop incorrect requirement for nft configs Phil Sutter
2019-11-06 11:47 ` Pablo Neira Ayuso
2019-11-06 14:19   ` Phil Sutter
2019-11-06 20:25     ` Pablo Neira Ayuso
2019-11-06 20:27       ` Pablo Neira Ayuso
2019-11-06 20:50         ` Phil Sutter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191106205052.GV15063@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).