From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CECA5C43331 for ; Tue, 12 Nov 2019 11:14:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEEA92084E for ; Tue, 12 Nov 2019 11:14:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726497AbfKLLO0 (ORCPT ); Tue, 12 Nov 2019 06:14:26 -0500 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:45442 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbfKLLO0 (ORCPT ); Tue, 12 Nov 2019 06:14:26 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1iUU7s-0000pB-6b; Tue, 12 Nov 2019 12:14:24 +0100 Date: Tue, 12 Nov 2019 12:14:24 +0100 From: Florian Westphal To: Manoj Basapathi Cc: netfilter-devel@vger.kernel.org, subashab@quicinc.com, sharathv@qti.qualcomm.com, ssaha@qti.qualcomm.com, vidulak@qti.qualcomm.com, bryanh@quicinc.com, jovanar@qti.qualcomm.com, manojbm@qti.qualcomm.com Subject: Re: [PATCH] netfilter: xtables: Add snapshot of hardidletimer target Message-ID: <20191112111424.GE19558@breakpoint.cc> References: <20191111065617.GA29048@manojbm-linux.ap.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191111065617.GA29048@manojbm-linux.ap.qualcomm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Manoj Basapathi wrote: > When the timer expires, the target module sends a sysfs notification > to the userspace, which can then decide what to do (eg. disconnect to > save power) > > Compared to xt_IDLETIMER, xt_HARDIDLETIMER can send notifications when > CPU is in suspend too, to notify the timer expiry. Would it make sense to add this feature to IDLETIMER instead of a new module? AFAICS there is a lot of boilerplate overlap between those two.