From: Florian Westphal <fw@strlen.de>
To: Duncan Roe <duncan_roe@optusnet.com.au>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libnetfilter_queue 1/1] src: Comment-out code not needed since Linux 3.8 in examples/nf-queue.c
Date: Sun, 24 Nov 2019 15:45:47 +0100 [thread overview]
Message-ID: <20191124144547.GB21689@breakpoint.cc> (raw)
In-Reply-To: <20191123051657.18308-2-duncan_roe@optusnet.com.au>
Duncan Roe <duncan_roe@optusnet.com.au> wrote:
> This makes it clear which lines are no longer required.
> It also obviates the need to document NFQNL_CFG_CMD_PF_(UN)BIND.
Why not simply #if 0 this code?
Or just delete it, v3.8 was released almost 7 years ago.
next prev parent reply other threads:[~2019-11-24 14:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 5:16 [PATCH libnetfilter_queue 0/1] src: Comment-out code not needed since Linux 3.8 in examples/nf-queue.c Duncan Roe
2019-11-23 5:16 ` [PATCH libnetfilter_queue 1/1] " Duncan Roe
2019-11-24 14:45 ` Florian Westphal [this message]
2019-11-24 23:52 ` Duncan Roe
2019-11-25 21:10 ` Pablo Neira Ayuso
2019-11-26 10:25 ` [PATCH libnetfilter_queue v2] src: Delete " Duncan Roe
2019-11-26 10:44 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124144547.GB21689@breakpoint.cc \
--to=fw@strlen.de \
--cc=duncan_roe@optusnet.com.au \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).