Linux Netfilter development
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, fw@strlen.de
Subject: Re: [PATCH nft 0/3] typeof incremental enhancements
Date: Mon, 16 Dec 2019 13:47:49 +0100	[thread overview]
Message-ID: <20191216124749.GR795@breakpoint.cc> (raw)
In-Reply-To: <20191216124222.356618-1-pablo@netfilter.org>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Hi Florian,
> 
> This patchset removes the need to self invoke the parser and the
> evaluation to fetch the datatype. Instead, the expression type and
> the expression description are stored into the userdata area.
> 
> This patch only supports for the payload expression, but it should be
> relatively easy to extend it to support for other existing expressions
> types.
> 
> This patch could be squashed into 06/11 src: add "typeof" print support
> of your patch series, which is actually not just adding support for
> printing but also for building the userdata.

I had considered that but found that storing netlink data
needs more space in the udata area compared to text and it needs more/extra
parsing for serialize/deserialize, so I abandoned this idea.

If you think its the way to go, then ok, I can rework it but
I will be unable to add the extra steps for other expression types
for some time I fear.

  parent reply	other threads:[~2019-12-16 12:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 12:42 [PATCH nft 0/3] typeof incremental enhancements Pablo Neira Ayuso
2019-12-16 12:42 ` [PATCH nft 1/3] proto: add proto_desc_id enumeration Pablo Neira Ayuso
2019-12-16 12:42 ` [PATCH nft 2/3] expr: add expr_ops_by_type() Pablo Neira Ayuso
2019-12-16 12:42 ` [PATCH nft 3/3] expr: add parse and build userdata interface Pablo Neira Ayuso
2019-12-16 12:47 ` Florian Westphal [this message]
2019-12-16 13:00   ` [PATCH nft 0/3] typeof incremental enhancements Pablo Neira Ayuso
2019-12-16 14:03     ` Florian Westphal
2019-12-16 15:01       ` Pablo Neira Ayuso
2019-12-16 15:48         ` Florian Westphal
2019-12-16 17:37           ` Pablo Neira Ayuso
2019-12-16 18:59             ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191216124749.GR795@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox