From: Stefano Brivio <sbrivio@redhat.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org,
"Pablo Neira Ayuso" <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org,
"Florian Westphal" <fw@strlen.de>,
"Kadlecsik József" <kadlec@blackhole.kfki.hu>,
"Eric Garver" <eric@garver.life>, "Phil Sutter" <phil@nwl.cc>
Subject: Re: [PATCH nf-next v3 5/9] nf_tables: Add set type for arbitrary concatenation of ranges
Date: Mon, 20 Jan 2020 23:05:41 +0100 [thread overview]
Message-ID: <20200120230541.64a3a556@elisabeth> (raw)
In-Reply-To: <202001202149.6obFNaHi%lkp@intel.com>
On Tue, 21 Jan 2020 00:13:17 +0800
kbuild test robot <lkp@intel.com> wrote:
> All errors (new ones prefixed by >>):
>
> >> ERROR: "__udivdi3" [net/netfilter/nf_tables_set.ko] undefined!
> >> ERROR: "__divdi3" [net/netfilter/nf_tables_set.ko] undefined!
Right, this needs:
diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c
index 5946fba8eb84..f0cb1e13af50 100644
--- a/net/netfilter/nft_set_pipapo.c
+++ b/net/netfilter/nft_set_pipapo.c
@@ -1925,7 +1925,7 @@ static bool nft_pipapo_estimate(const struct nft_set_desc *desc, u32 features,
/* Rules in lookup and mapping tables are needed for each entry */
est->size = desc->size * entry_size;
- if (est->size && est->size / desc->size != entry_size)
+ if (est->size && div_u64(est->size, desc->size) != entry_size)
return false;
est->size += sizeof(struct nft_pipapo) +
I will change that in the next version.
--
Stefano
next prev parent reply other threads:[~2020-01-20 22:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 13:33 [PATCH nf-next v3 0/9] nftables: Set implementation for arbitrary concatenation of ranges Stefano Brivio
2020-01-19 13:33 ` [PATCH nf-next v3 1/9] netfilter: nf_tables: add nft_setelem_parse_key() Stefano Brivio
2020-01-19 13:33 ` [PATCH nf-next v3 2/9] netfilter: nf_tables: add NFTA_SET_ELEM_KEY_END attribute Stefano Brivio
2020-01-19 13:33 ` [PATCH nf-next v3 3/9] netfilter: nf_tables: Support for sets with multiple ranged fields Stefano Brivio
2020-01-19 13:33 ` [PATCH nf-next v3 4/9] bitmap: Introduce bitmap_cut(): cut bits and shift remaining Stefano Brivio
2020-01-19 13:33 ` [PATCH nf-next v3 5/9] nf_tables: Add set type for arbitrary concatenation of ranges Stefano Brivio
2020-01-20 16:13 ` kbuild test robot
2020-01-20 22:05 ` Stefano Brivio [this message]
2020-01-19 13:33 ` [PATCH nf-next v3 6/9] selftests: netfilter: Introduce tests for sets with range concatenation Stefano Brivio
2020-01-19 13:33 ` [PATCH nf-next v3 7/9] nft_set_pipapo: Prepare for vectorised implementation: alignment Stefano Brivio
2020-01-19 13:33 ` [PATCH nf-next v3 8/9] nft_set_pipapo: Prepare for vectorised implementation: helpers Stefano Brivio
2020-01-19 13:33 ` [PATCH nf-next v3 9/9] nft_set_pipapo: Introduce AVX2-based lookup implementation Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120230541.64a3a556@elisabeth \
--to=sbrivio@redhat.com \
--cc=eric@garver.life \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=kbuild-all@lists.01.org \
--cc=lkp@intel.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).