From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30C61C3524D for ; Mon, 3 Feb 2020 12:06:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 133CA20661 for ; Mon, 3 Feb 2020 12:06:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727824AbgBCMGf (ORCPT ); Mon, 3 Feb 2020 07:06:35 -0500 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:57890 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727794AbgBCMGf (ORCPT ); Mon, 3 Feb 2020 07:06:35 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1iyaUr-0003tF-Ih; Mon, 03 Feb 2020 13:06:33 +0100 Date: Mon, 3 Feb 2020 13:06:33 +0100 From: Florian Westphal To: Cong Wang Cc: netdev@vger.kernel.org, fw@strlen.de, netfilter-devel@vger.kernel.org, syzbot+adf6c6c2be1c3a718121@syzkaller.appspotmail.com, Pablo Neira Ayuso , Jozsef Kadlecsik Subject: Re: [Patch nf v2 3/3] xt_hashlimit: limit the max size of hashtable Message-ID: <20200203120633.GQ795@breakpoint.cc> References: <20200203043053.19192-1-xiyou.wangcong@gmail.com> <20200203043053.19192-4-xiyou.wangcong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200203043053.19192-4-xiyou.wangcong@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Cong Wang wrote: > The user-specified hashtable size is unbound, this could > easily lead to an OOM or a hung task as we hold the global > mutex while allocating and initializing the new hashtable. Reviewed-by: Florian Westphal