From: Florian Westphal <fw@strlen.de>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next 2/2] netfilter: nf_tables: make all set structs const
Date: Mon, 17 Feb 2020 16:02:05 +0100 [thread overview]
Message-ID: <20200217150205.GD19559@breakpoint.cc> (raw)
In-Reply-To: <20200217155048.00c477a3@redhat.com>
Stefano Brivio <sbrivio@redhat.com> wrote:
> > -struct nft_set_type nft_set_pipapo_type __read_mostly = {
> > - .owner = THIS_MODULE,
> > +const struct nft_set_type nft_set_pipapo_type __read_mostly = {
>
> const ... read_mostly should make no sense because const already forces
> the data to a read-only segment. It might actually cause some issues,
> see https://lore.kernel.org/patchwork/patch/439824/.
>
> It's not there for the other set types, so I'm assuming it's a typo :)
Grrr, thanks for noticing. This came from an old branch that
was before pipapo got merged.
I will wait some more and then send a v2.
prev parent reply other threads:[~2020-02-17 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 9:53 [PATCH nf-next 0/2] netfilter: nf_tables: make sets built-in Florian Westphal
2020-02-17 9:53 ` [PATCH nf-next 1/2] " Florian Westphal
2020-02-17 9:53 ` [PATCH nf-next 2/2] netfilter: nf_tables: make all set structs const Florian Westphal
2020-02-17 14:50 ` Stefano Brivio
2020-02-17 15:02 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217150205.GD19559@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).