From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9CCCC35670 for ; Sun, 23 Feb 2020 23:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1CFB20880 for ; Sun, 23 Feb 2020 23:15:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727156AbgBWXPe (ORCPT ); Sun, 23 Feb 2020 18:15:34 -0500 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:45866 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727133AbgBWXPe (ORCPT ); Sun, 23 Feb 2020 18:15:34 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1j60TA-0004aQ-0o; Mon, 24 Feb 2020 00:15:28 +0100 Date: Mon, 24 Feb 2020 00:15:28 +0100 From: Florian Westphal To: Stefano Brivio Cc: Florian Westphal , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf-next 3/5] nft_set_pipapo: Prepare for vectorised implementation: alignment Message-ID: <20200223231528.GD19559@breakpoint.cc> References: <2723f85da2cd9d6b7158c7a2514c6b22f044b1b6.1582488826.git.sbrivio@redhat.com> <20200223221435.GX19559@breakpoint.cc> <20200224000429.7997696b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200224000429.7997696b@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Stefano Brivio wrote: > '*scratch' is actually needed at lookup time for implementations that > don't need stricter alignment than natural one, but I could probably > use some macro trickery and "move" it as needed. Ah I see, don't bother then for now. > I'm not sure how to deal with fields after f[0], syntactically. Do you > have some, er, pointers? Don't bother, its very ugly. Base hook chains do this, it involves a comment at the tail of the struct, see struct nf_hook_entries in include/linux/netfilter.h.