netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Netfilter Development <netfilter-devel@vger.kernel.org>,
	Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH libnetfilter_queue] src: add nfq_get_skbinfo()
Date: Mon, 24 Feb 2020 11:16:48 +0100	[thread overview]
Message-ID: <20200224101648.GF19559@breakpoint.cc> (raw)
In-Reply-To: <20200224010344.GA3564@dimstar.local.net>

Duncan Roe <duncan_roe@optusnet.com.au> wrote:
> Can I suggest:
> 
>   > + *   example because this is an incoming packet and the NIC does not
>   > + *   perform checksum validation at hardware level.
> - > + * See nfq_set_queue_flags() documentation for more information.
>   > + *
>   > + * \return the skbinfo value
> + > + * \sa __nfq_set_queue_flags__(3)
>   > + */
>   > +EXPORT_SYMBOL
> 
> I think this will look better, especially on the man page.

Its does, thanks.  I've made this change in my local tree.

  reply	other threads:[~2020-02-24 10:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-23 23:49 [PATCH libnetfilter_queue] src: add nfq_get_skbinfo() Florian Westphal
2020-02-24  1:03 ` Duncan Roe
2020-02-24 10:16   ` Florian Westphal [this message]
2020-02-24 23:19     ` Duncan Roe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200224101648.GF19559@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).