From: Stefano Brivio <sbrivio@redhat.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>, fw@strlen.de
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] segtree: bail out on concatenations
Date: Fri, 3 Apr 2020 02:54:53 +0200 [thread overview]
Message-ID: <20200403025453.7c5f00ba@elisabeth> (raw)
In-Reply-To: <20200402214941.60097-1-pablo@netfilter.org>
Hi,
On Thu, 2 Apr 2020 23:49:41 +0200
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> This patch adds a lazy check to validate that the first element is not a
> concatenation. The segtree code does not support for concatenations,
> bail out with EOPNOTSUPP.
>
> # nft add element x y { 10.0.0.0/8 . 192.168.1.3-192.168.1.9 . 1024-65535 }
> Error: Could not process rule: Operation not supported
> add element x y { 10.0.0.0/8 . 192.168.1.3-192.168.1.9 . 1024-65535 }
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Otherwise, the segtree code barfs with:
>
> BUG: invalid range expression type concat
>
> Reported-by: Florian Westphal <fw@strlen.de>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
I know you both reported this to me, sorry, I still have to polish up
the actual fix before posting it. I'm not very familiar with this code
yet, and it's taking ages.
It might be a few more days before I get to it, so I guess this patch
might make sense for the moment being.
--
Stefano
next prev parent reply other threads:[~2020-04-03 0:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 21:49 [PATCH] segtree: bail out on concatenations Pablo Neira Ayuso
2020-04-03 0:54 ` Stefano Brivio [this message]
2020-04-03 10:39 ` Pablo Neira Ayuso
2020-04-03 10:43 ` Stefano Brivio
2020-04-03 12:03 ` Pablo Neira Ayuso
2020-04-03 12:05 ` Pablo Neira Ayuso
2020-04-03 12:27 ` Stefano Brivio
2020-04-03 12:50 ` Pablo Neira Ayuso
2020-04-03 13:33 ` Stefano Brivio
2020-04-03 14:12 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403025453.7c5f00ba@elisabeth \
--to=sbrivio@redhat.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox