From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Matt Turner <mattst88@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nftables] doc: Include generated man pages in dist tarball
Date: Sun, 19 Apr 2020 18:43:30 +0200 [thread overview]
Message-ID: <20200419164330.tn7ov4qm3o7mde2f@salvia> (raw)
In-Reply-To: <20200407190508.21496-1-mattst88@gmail.com>
On Tue, Apr 07, 2020 at 12:05:08PM -0700, Matt Turner wrote:
> Most projects ship pre-generated man pages in the distribution tarball
> so that builders don't need the documentation tools installed, similar
> to how bison-generated sources are included.
>
> To do this, we conditionalize the presence check of a2x on whether nft.8
> already exists in the source directory, as it would exist if included in
> the distribution tarball.
>
> Secondly, we move the 'if BUILD_MAN' conditional to around the man page
> generation rules. This ensures that the man pages are unconditionally
> installed. Also only add the man pages to CLEANFILES if their generation
> is enabled.
Applied, thanks.
prev parent reply other threads:[~2020-04-19 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 19:05 [PATCH nftables] doc: Include generated man pages in dist tarball Matt Turner
2020-04-17 19:38 ` Matt Turner
2020-04-19 16:43 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200419164330.tn7ov4qm3o7mde2f@salvia \
--to=pablo@netfilter.org \
--cc=mattst88@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox