netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florent Fourcot <florent.fourcot@wifirst.fr>
Cc: Romain Bellan <romain.bellan@wifirst.fr>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next v5 1/1] netfilter: ctnetlink: add kernel side filtering for dump
Date: Tue, 5 May 2020 21:14:03 +0200	[thread overview]
Message-ID: <20200505191403.GA4129@salvia> (raw)
In-Reply-To: <66100a4b-a879-a8f4-f684-2b098a89cdc8@wifirst.fr>

Hello Florent,

On Mon, May 04, 2020 at 09:37:37PM +0200, Florent Fourcot wrote:
> Hello Pablo,
> 
> We just posted a v6. We hope that this one will be the good one.

Thanks, I'll review asap.

> > The test this needs to be compiled via:
> > 
> >          gcc -lnetfilter_conntrack test-conntrack.c -o test
> > 
> 
> Thanks for the pointer, it helped us a lot, it was not clear before for us
> how to test it.

I should have said since the beginning, I forgot about these tests
when reviewing.

> We applied patch on top of current net-next HEAD and it looks good for this
> one (OK: 122 BAD: 0).

Great.

I'll review asap.

  reply	other threads:[~2020-05-05 19:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30 20:46 [PATCH nf-next v5 1/1] netfilter: ctnetlink: add kernel side filtering for dump Romain Bellan
2020-04-26 21:43 ` Pablo Neira Ayuso
2020-05-04 19:37   ` Florent Fourcot
2020-05-05 19:14     ` Pablo Neira Ayuso [this message]
2020-05-29 18:04     ` Pablo Neira Ayuso
2020-06-04 16:08       ` Florent Fourcot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200505191403.GA4129@salvia \
    --to=pablo@netfilter.org \
    --cc=florent.fourcot@wifirst.fr \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=romain.bellan@wifirst.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).