From: Duncan Roe <duncan_roe@optusnet.com.au>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Duncan Roe <duncan_roe@optusnet.com.au>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libnetfilter_queue 1/1] src: add pktb_alloc2() and pktb_head_size()
Date: Mon, 11 May 2020 07:30:07 +1000 [thread overview]
Message-ID: <20200510213007.GG26529@dimstar.local.net> (raw)
In-Reply-To: <20200510151001.GA6216@salvia>
On Sun, May 10, 2020 at 05:10:01PM +0200, Pablo Neira Ayuso wrote:
> On Sun, May 10, 2020 at 11:53:17PM +1000, Duncan Roe wrote:
> > pktb_alloc2() avoids the malloc/free overhead in pktb_alloc() and also
> > eliminates memcpy() of the payload except when mangling increases the
> > packet length.
> >
> > - pktb_mangle() does the memcpy() if need be.
> > Packet metadata is altered in this case
> > - All the _mangle functions are altered to account for possible change tp
> > packet metadata
> > - Documentation is updated
>
> Many chunks of this patchset look very much the same I posted. I'll
> apply my patchset and please rebase any update on top of it.
Your patchset is crap.
No documentation, giant holes that I haven't had time to reply to...
Apply this junk and I am walking away from netfilter.
>
> Thanks.
-Duncan
next prev parent reply other threads:[~2020-05-10 21:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 13:53 [PATCH libnetfilter_queue 0/1] pktb_alloc2() Duncan Roe
2020-05-10 13:53 ` [PATCH libnetfilter_queue 1/1] src: add pktb_alloc2() and pktb_head_size() Duncan Roe
2020-05-10 15:10 ` Pablo Neira Ayuso
2020-05-10 21:30 ` Duncan Roe [this message]
2020-05-13 6:49 ` Duncan Roe
2020-05-13 6:49 ` [PATCH libnetfilter_queue 1/1] src & doc: Rename pktb_alloc2 to pktb_setup Duncan Roe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510213007.GG26529@dimstar.local.net \
--to=duncan_roe@optusnet.com.au \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox