From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Matt Turner <mattst88@gmail.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] build: Fix doc build, restore A2X assignment for doc/Makefile
Date: Mon, 25 May 2020 22:04:15 +0200 [thread overview]
Message-ID: <20200525200415.GA14991@salvia> (raw)
In-Reply-To: <8ef909eedea05cdd3072bea59d664e3a52e28dcd.1590320436.git.sbrivio@redhat.com>
On Sun, May 24, 2020 at 02:59:36PM +0200, Stefano Brivio wrote:
> Commit 4f2813a313ae ("build: Include generated man pages in dist
> tarball") skips AC_CHECK_PROG for A2X altogether if doc/nft.8 is
> already present.
>
> Now, starting from a clean situation, we can have this sequence:
> ./configure # doc/nft.8 not there, A2X set in doc/Makefile
> make # builds doc/nft.8
> ./configure # doc/nft.8 is there, A2X left empty in doc/Makefile
> make clean # removes doc/nft.8
> make
>
> resulting in:
>
> [...]
> GEN nft.8
> /bin/sh: -L: command not found
> make[2]: *** [Makefile:639: nft.8] Error 127
>
> and the only way to get out of this is to issue ./configure again
> after make clean, which is rather unexpected.
>
> Instead of skipping AC_CHECK_PROG when doc/nft.8 is present, keep
> it and simply avoid returning failure if a2x(1) is not available but
> doc/nft.8 was built, so that A2X is properly set in doc/Makefile
> whenever needed.
Applied, thanks.
prev parent reply other threads:[~2020-05-25 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 12:59 [PATCH nft] build: Fix doc build, restore A2X assignment for doc/Makefile Stefano Brivio
2020-05-25 15:52 ` Phil Sutter
2020-05-25 20:04 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525200415.GA14991@salvia \
--to=pablo@netfilter.org \
--cc=mattst88@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).