From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 694B8C433DF for ; Wed, 27 May 2020 09:52:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43AB720B80 for ; Wed, 27 May 2020 09:52:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728289AbgE0Jwk (ORCPT ); Wed, 27 May 2020 05:52:40 -0400 Received: from correo.us.es ([193.147.175.20]:45214 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726012AbgE0Jwk (ORCPT ); Wed, 27 May 2020 05:52:40 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 46E9AF23BC for ; Wed, 27 May 2020 11:52:38 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3A737DA717 for ; Wed, 27 May 2020 11:52:38 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 350EFDA72A; Wed, 27 May 2020 11:52:38 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 2AD4BDA70F; Wed, 27 May 2020 11:52:36 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 27 May 2020 11:52:36 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id ECBA542EE38F; Wed, 27 May 2020 11:52:35 +0200 (CEST) Date: Wed, 27 May 2020 11:52:35 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Nathan Chancellor Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH net] netfilter: conntrack: Pass value of ctinfo to __nf_conntrack_update Message-ID: <20200527095235.GA399@salvia> References: <20200527081038.3506095-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200527081038.3506095-1-natechancellor@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, May 27, 2020 at 01:10:39AM -0700, Nathan Chancellor wrote: > Clang warns: > > net/netfilter/nf_conntrack_core.c:2068:21: warning: variable 'ctinfo' is > uninitialized when used here [-Wuninitialized] > nf_ct_set(skb, ct, ctinfo); > ^~~~~~ > net/netfilter/nf_conntrack_core.c:2024:2: note: variable 'ctinfo' is > declared here > enum ip_conntrack_info ctinfo; > ^ > 1 warning generated. > > nf_conntrack_update was split up into nf_conntrack_update and > __nf_conntrack_update, where the assignment of ctifno is in > nf_conntrack_update but it is used in __nf_conntrack_update. > > Pass the value of ctinfo from nf_conntrack_update to > __nf_conntrack_update so that uninitialized memory is not used > and everything works properly. Applied, thanks.