From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Phil Sutter <phil@nwl.cc>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft v2 0/2] Fix evaluation of anonymous sets with concatenated ranges
Date: Thu, 28 May 2020 02:09:45 +0200 [thread overview]
Message-ID: <20200528000945.GA11541@salvia> (raw)
In-Reply-To: <cover.1590612113.git.sbrivio@redhat.com>
On Wed, May 27, 2020 at 10:51:20PM +0200, Stefano Brivio wrote:
> As reported by both Pablo and Phil, trying to add an anonymous set
> containing a concatenated range would fail:
>
> # nft add rule x y ip saddr . tcp dport { 192.168.2.1 . 20-30 } accept
> BUG: invalid range expression type concat
> nft: expression.c:1160: range_expr_value_low: Assertion `0' failed.
> Aborted
>
> # nft add rule t c ip daddr . tcp dport '{ 10.0.0.0/8 . 10-23, 192.168.1.1-192.168.3.8 . 80-443 } accept'
> BUG: invalid range expression type concat
> nft: expression.c:1296: range_expr_value_low: Assertion `0' failed.
>
> Patch 1/2 fixes this, and 2/2 enables a test for it in inet/sets.t.
Series applied, thanks Stefano.
prev parent reply other threads:[~2020-05-28 0:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 20:51 [PATCH nft v2 0/2] Fix evaluation of anonymous sets with concatenated ranges Stefano Brivio
2020-05-27 20:51 ` [PATCH nft v2 1/2] evaluate: Perform set evaluation on implicitly declared (anonymous) sets Stefano Brivio
2020-05-27 20:51 ` [PATCH nft v2 2/2] tests: py: Enable anonymous set rule with concatenated ranges in inet/sets.t Stefano Brivio
2020-05-28 0:09 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528000945.GA11541@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).