From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] include: Avoid undefined left-shift in xt_sctp.h
Date: Fri, 29 May 2020 20:26:09 +0200 [thread overview]
Message-ID: <20200529182609.GA31813@salvia> (raw)
In-Reply-To: <20200529181022.21855-1-phil@nwl.cc>
On Fri, May 29, 2020 at 08:10:22PM +0200, Phil Sutter wrote:
> Pull the fix in kernel commit 164166558aace ("netfilter: uapi: Avoid
> undefined left-shift in xt_sctp.h") into iptables repository. The
> original description is:
>
> With 'bytes(__u32)' being 32, a left-shift of 31 may happen which is
> undefined for the signed 32-bit value 1. Avoid this by declaring 1 as
> unsigned.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Thanks Phil.
prev parent reply other threads:[~2020-05-29 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 18:10 [iptables PATCH] include: Avoid undefined left-shift in xt_sctp.h Phil Sutter
2020-05-29 18:26 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529182609.GA31813@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).