From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH nft 1/2] segtree: fix asan runtime error
Date: Sun, 7 Jun 2020 20:04:43 +0200 [thread overview]
Message-ID: <20200607180444.17736-1-pablo@netfilter.org> (raw)
ASAN reports:
segtree.c:387:30: runtime error: variable length array bound evaluates to non-positive value 0
Update array definition to be the set size plus 1.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/segtree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/segtree.c b/src/segtree.c
index 266a2b4dc98b..b6ca6083ea0b 100644
--- a/src/segtree.c
+++ b/src/segtree.c
@@ -383,8 +383,8 @@ static bool interval_overlap(const struct elementary_interval *e1,
static int set_overlap(struct list_head *msgs, const struct set *set,
struct expr *init, unsigned int keylen, bool add)
{
- struct elementary_interval *new_intervals[init->size];
- struct elementary_interval *intervals[set->init->size];
+ struct elementary_interval *new_intervals[init->size + 1];
+ struct elementary_interval *intervals[set->init->size + 1];
unsigned int n, m, i, j;
int ret = 0;
--
2.20.1
next reply other threads:[~2020-06-07 18:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 18:04 Pablo Neira Ayuso [this message]
2020-06-07 18:04 ` [PATCH nft 2/2] meta: fix asan runtime error in tc handle Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200607180444.17736-1-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).