From: Stefano Brivio <sbrivio@redhat.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, nucleo@fedoraproject.org
Subject: Re: [PATCH nft,v2] evaluate: missing datatype definition in implicit_set_declaration()
Date: Sun, 7 Jun 2020 18:06:14 +0200 [thread overview]
Message-ID: <20200607180614.2146750e@elisabeth> (raw)
In-Reply-To: <20200607134007.1798-1-pablo@netfilter.org>
On Sun, 7 Jun 2020 15:40:07 +0200
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> set->data from implicit_set_declaration(), otherwise, set_evaluation()
> bails out with:
>
> # nft -f /etc/nftables/inet-filter.nft
> /etc/nftables/inet-filter.nft:8:32-54: Error: map definition does not specify
> mapping data type
> tcp dport vmap { 22 : jump ssh_input }
> ^^^^^^^^^^^^^^^^^^^^^^^
> /etc/nftables/inet-filter.nft:13:26-52: Error: map definition does not specify
> mapping data type
> iif vmap { "eth0" : jump wan_input }
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Add a test to cover this case.
>
> Fixes: 7aa08d45031e ("evaluate: Perform set evaluation on implicitly declared (anonymous) sets")
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=208093
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Whoops, sorry, I didn't think of that case at all. Thanks for fixing it.
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
prev parent reply other threads:[~2020-06-07 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 13:40 [PATCH nft,v2] evaluate: missing datatype definition in implicit_set_declaration() Pablo Neira Ayuso
2020-06-07 16:06 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200607180614.2146750e@elisabeth \
--to=sbrivio@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=nucleo@fedoraproject.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).