From: Phil Sutter <phil@nwl.cc>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: "Pablo Neira Ayuso" <pablo@netfilter.org>,
"Laura García Liébana" <nevola@gmail.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: shell: Drop redefinition of DIFF variable
Date: Mon, 15 Jun 2020 11:00:44 +0200 [thread overview]
Message-ID: <20200615090044.GH23632@orbyte.nwl.cc> (raw)
In-Reply-To: <bdced35aa00b7933e8b67a52b37754d0b6f86f59.1592170402.git.sbrivio@redhat.com>
Hi Stefano,
On Sun, Jun 14, 2020 at 11:41:49PM +0200, Stefano Brivio wrote:
> Commit 7d93e2c2fbc7 ("tests: shell: autogenerate dump verification")
> introduced the definition of DIFF at the top of run-tests.sh, to make
> it visually part of the configuration section. Commit 68310ba0f9c2
> ("tests: shell: Search diff tool once and for all") override this
> definition.
>
> Drop the unexpected redefinition of DIFF.
I would fix it the other way round, dropping the first definition. It's
likely a missing bit from commit 68310ba0f9c20, the second definition is
in line with FIND and MODPROBE definitions immediately preceding it.
Cheers, Phil
next prev parent reply other threads:[~2020-06-15 9:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 21:41 [PATCH nft] tests: shell: Drop redefinition of DIFF variable Stefano Brivio
2020-06-15 9:00 ` Phil Sutter [this message]
2020-06-15 10:18 ` Stefano Brivio
2020-06-15 11:54 ` Phil Sutter
2020-06-15 12:40 ` Stefano Brivio
2020-06-15 13:21 ` Phil Sutter
2020-06-15 14:36 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615090044.GH23632@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=nevola@gmail.com \
--cc=pablo@netfilter.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox