From: Florian Westphal <fw@strlen.de>
To: wenxu <wenxu@ucloud.cn>
Cc: Florian Westphal <fw@strlen.de>,
davem@davemloft.net, pablo@netfilter.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] netfilter: nf_defrag_ipv4: Add nf_ct_frag_gather support
Date: Mon, 6 Jul 2020 18:29:15 +0200 [thread overview]
Message-ID: <20200706162915.GB32005@breakpoint.cc> (raw)
In-Reply-To: <06700aee-f62f-7b83-de21-4f5b4928978e@ucloud.cn>
wenxu <wenxu@ucloud.cn> wrote:
>
> 在 2020/7/6 22:38, Florian Westphal 写道:
> > wenxu@ucloud.cn <wenxu@ucloud.cn> wrote:
> >> From: wenxu <wenxu@ucloud.cn>
> >>
> >> Add nf_ct_frag_gather for conntrack defrag and it will
> >> elide the CB clear when packets are defragmented by
> >> connection tracking
> > Why is this patch required?
> > Can't you rework ip_defrag to avoid the cb clear if you need that?
>
> The ip_defrag used by ip stack and can work with the cb setting.
Yes, but does it have to?
If yes, why does nf_ct_frag not need it whereas ip_defrag has to?
> Defragment case only for conntrack maybe need to avoid the cb
>
> clear. So it is more clear to nf_ct_frag_gather for conntrack like the
>
> function nf_ct_frag6_gather for ipv6.
nf_ct_frag6_gather() is only re-using less code from ipv6 for historical
reasons. If anything, ipv6 conntrack defrag should re-use more code from
ipv6 defrag, rather than making ipv4 conntrack defrag look more like
ipv6 conntrack defrag.
next prev parent reply other threads:[~2020-07-06 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 14:28 [PATCH net-next 0/3] make nf_ct_frag/6_gather elide the skb CB clear wenxu
2020-07-05 14:28 ` [PATCH net-next 1/3] netfilter: nf_defrag_ipv4: Add nf_ct_frag_gather support wenxu
2020-07-06 5:40 ` Cong Wang
2020-07-06 14:38 ` Florian Westphal
2020-07-06 15:08 ` wenxu
2020-07-06 16:29 ` Florian Westphal [this message]
2020-07-07 4:47 ` wenxu
2020-07-05 14:28 ` [PATCH net-next 2/3] netfilter: nf_conntrack_reasm: make nf_ct_frag6_gather elide the CB clear wenxu
2020-07-05 14:28 ` [PATCH net-next 3/3] net/sched: act_ct: fix clobber qdisc_skb_cb in defrag wenxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706162915.GB32005@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).