From: Giuseppe Scrivano <gscrivan@redhat.com>
To: netfilter-devel@vger.kernel.org
Cc: gscrivan@redhat.com, Phil Sutter <phil@nwl.cc>,
Florian Westphal <fw@strlen.de>
Subject: [iptables PATCH v2] iptables: accept lock file name at runtime
Date: Wed, 15 Jul 2020 08:51:52 +0200 [thread overview]
Message-ID: <20200715065152.4172896-1-gscrivan@redhat.com> (raw)
allow users to override at runtime the lock file to use through the
XTABLES_LOCKFILE environment variable.
It allows using iptables from a network namespace owned by an user
that has no write access to XT_LOCK_NAME (by default under /run), and
without setting up a new mount namespace.
$ XTABLES_LOCKFILE=/tmp/xtables unshare -rn iptables ...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
---
iptables/xshared.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/iptables/xshared.c b/iptables/xshared.c
index c1d1371a..caf1dfcc 100644
--- a/iptables/xshared.c
+++ b/iptables/xshared.c
@@ -249,12 +249,17 @@ void xs_init_match(struct xtables_match *match)
static int xtables_lock(int wait, struct timeval *wait_interval)
{
struct timeval time_left, wait_time;
+ const char *lock_file;
int fd, i = 0;
time_left.tv_sec = wait;
time_left.tv_usec = 0;
- fd = open(XT_LOCK_NAME, O_CREAT, 0600);
+ lock_file = getenv("XTABLES_LOCKFILE");
+ if (lock_file == NULL || lock_file[0] == '\0')
+ lock_file = XT_LOCK_NAME;
+
+ fd = open(lock_file, O_CREAT, 0600);
if (fd < 0) {
fprintf(stderr, "Fatal: can't open lock file %s: %s\n",
XT_LOCK_NAME, strerror(errno));
--
2.26.2
next reply other threads:[~2020-07-15 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 6:51 Giuseppe Scrivano [this message]
2020-07-16 21:55 ` [iptables PATCH v2] iptables: accept lock file name at runtime Phil Sutter
2020-07-17 8:18 ` Giuseppe Scrivano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715065152.4172896-1-gscrivan@redhat.com \
--to=gscrivan@redhat.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).