From: Florian Westphal <fw@strlen.de>
To: Michael Zhou <mzhou@cse.unsw.edu.au>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: TEST Re: [PATCH] net/ipv6/netfilter/ip6t_NPT: rewrite addresses in ICMPv6 original packet
Date: Fri, 31 Jul 2020 00:28:08 +0200 [thread overview]
Message-ID: <20200730222808.GF5271@breakpoint.cc> (raw)
In-Reply-To: <20200730141503.3eb212db@dvsy1.host.maki.stream>
Michael Zhou <mzhou@cse.unsw.edu.au> wrote:
> Thanks for the comments.
>
> On Wed, 29 Jul 2020 22:43:23 +0200
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> > This ICMPv6 header might fall withing the non-linear data of the
> > skbuff.
>
> Might you be able to point me to an example of how to handle and test
> this? So far in my testing it has always been in the linear data.
Look at skb_header_pointer() function and other users of it.
> > BTW, does rfc6296 describes what to do with icmp traffic?
>
> Unfortunately not. Do you think this functionality should be an
> optional flag or be part of a different target to maintain conformance
> with the RFC?
Handling it automatically seems sane to me.
prev parent reply other threads:[~2020-07-30 22:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 13:17 [PATCH] net/ipv6/netfilter/ip6t_NPT: rewrite addresses in ICMPv6 original packet Michael Zhou
2020-07-29 20:43 ` Pablo Neira Ayuso
2020-07-30 22:14 ` TEST " Michael Zhou
2020-07-30 22:28 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730222808.GF5271@breakpoint.cc \
--to=fw@strlen.de \
--cc=mzhou@cse.unsw.edu.au \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).