From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: avoid ipv6 -> nf_defrag_ipv6 module dependency
Date: Tue, 11 Aug 2020 09:30:26 +0200 [thread overview]
Message-ID: <20200811073026.GD1403@salvia> (raw)
In-Reply-To: <20200810115215.369-1-fw@strlen.de>
On Mon, Aug 10, 2020 at 01:52:15PM +0200, Florian Westphal wrote:
> nf_ct_frag6_gather is part of nf_defrag_ipv6.ko, not ipv6 core.
>
> The current use of the netfilter ipv6 stub indirections causes a module
> dependency between ipv6 and nf_defrag_ipv6.
>
> This prevents nf_defrag_ipv6 module from being removed because ipv6 can't
> be unloaded.
>
> Remove the indirection and always use a direct call. This creates a
> depency from nf_conntrack_bridge to nf_defrag_ipv6 instead:
>
> modinfo nf_conntrack
> depends: nf_conntrack,nf_defrag_ipv6,bridge
>
> .. and nf_conntrack already depends on nf_defrag_ipv6 anyway.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> I can also re-send it when nf-next reopens later, whatever you prefer.
No problem, it can just sit here until net-next reopens.
next prev parent reply other threads:[~2020-08-11 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 11:52 [PATCH nf] netfilter: avoid ipv6 -> nf_defrag_ipv6 module dependency Florian Westphal
2020-08-11 7:30 ` Pablo Neira Ayuso [this message]
2020-08-11 7:30 ` Pablo Neira Ayuso
2020-08-13 2:17 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811073026.GD1403@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox