From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36861C433E0 for ; Thu, 13 Aug 2020 02:03:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B16520675 for ; Thu, 13 Aug 2020 02:03:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726542AbgHMCDS (ORCPT ); Wed, 12 Aug 2020 22:03:18 -0400 Received: from correo.us.es ([193.147.175.20]:60578 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726406AbgHMCDS (ORCPT ); Wed, 12 Aug 2020 22:03:18 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 23074DA8FF for ; Thu, 13 Aug 2020 04:03:17 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 1500FDA704 for ; Thu, 13 Aug 2020 04:03:17 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 0AC3FDA73F; Thu, 13 Aug 2020 04:03:17 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id EC8D1DA704; Thu, 13 Aug 2020 04:03:14 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 13 Aug 2020 04:03:14 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (246.pool85-48-185.static.orange.es [85.48.185.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 8294342EE38E; Thu, 13 Aug 2020 04:03:14 +0200 (CEST) Date: Thu, 13 Aug 2020 04:03:12 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Phil Sutter Cc: netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH] xtables-monitor: Fix ip6tables rule printing Message-ID: <20200813020312.GC3104@salvia> References: <20200807145100.21340-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200807145100.21340-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Fri, Aug 07, 2020 at 04:51:00PM +0200, Phil Sutter wrote: > When printing an ip6tables rule event, false family ops are used as they > are initially looked up for AF_INET and reused no matter the current > rule's family. In practice, this means that nft_rule_print_save() calls > the wrong rule_to_cs, save_rule and clear_cs callbacks. Therefore, if a > rule specifies a source or destination address, the address is not > printed. > > Fix this by performing a family lookup each time rule_cb is called. > > Signed-off-by: Phil Sutter Acked-by: Pablo Neira Ayuso