From: Stefano Brivio <sbrivio@redhat.com>
To: Balazs Scheidler <bazsi77@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nftables 4/4] tests: allow tests to use a custom nft executable
Date: Sat, 22 Aug 2020 11:15:13 +0200 [thread overview]
Message-ID: <20200822111513.5495cddb@elisabeth> (raw)
In-Reply-To: <20200822062203.3617-5-bazsi77@gmail.com>
Hi Balazs,
On Sat, 22 Aug 2020 08:22:03 +0200
Balazs Scheidler <bazsi77@gmail.com> wrote:
> diff --git a/tests/shell/run-tests.sh b/tests/shell/run-tests.sh
> index 943f8877..5233ba86 100755
> --- a/tests/shell/run-tests.sh
> +++ b/tests/shell/run-tests.sh
> @@ -2,7 +2,7 @@
>
> # Configuration
> TESTDIR="./$(dirname $0)/testcases"
> -SRC_NFT="$(dirname $0)/../../src/nft"
> +SRC_NFT=${NFT:-../../src/nft}
This isn't needed (and lacks quotes, won't work with a wrapper, e.g.
valgrind). It's already possible to pass a different nft executable
because later we have:
[ -z "$NFT" ] && NFT=$SRC_NFT
...now, you could in theory replace this assignment with the one you
proposed, but I think a SRC_NFT="../../src/nft" variable is more obvious
to configure compared to NFT="${NFT:../../src/nft}".
--
Stefano
prev parent reply other threads:[~2020-08-22 9:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 6:21 [PATCH nftables 0/4] socket: add support for "wildcard" key Balazs Scheidler
2020-08-22 6:22 ` [PATCH nftables 1/4] " Balazs Scheidler
2020-08-22 9:23 ` Stefano Brivio
2020-08-28 16:20 ` Pablo Neira Ayuso
2020-08-22 6:22 ` [PATCH nftables 2/4] doc: added documentation on "socket wildcard" Balazs Scheidler
2020-08-22 9:17 ` Stefano Brivio
2020-08-22 6:22 ` [PATCH nftables 3/4] tests: added "socked wildcard" testcases Balazs Scheidler
2020-08-22 9:16 ` Stefano Brivio
2020-08-22 6:22 ` [PATCH nftables 4/4] tests: allow tests to use a custom nft executable Balazs Scheidler
2020-08-22 9:15 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200822111513.5495cddb@elisabeth \
--to=sbrivio@redhat.com \
--cc=bazsi77@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).