From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2293EC433E1 for ; Thu, 27 Aug 2020 17:02:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 036CD20737 for ; Thu, 27 Aug 2020 17:02:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726246AbgH0RCG (ORCPT ); Thu, 27 Aug 2020 13:02:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726157AbgH0RCG (ORCPT ); Thu, 27 Aug 2020 13:02:06 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E42AAC061264 for ; Thu, 27 Aug 2020 10:02:05 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94) (envelope-from ) id 1kBLHn-0005gP-O3; Thu, 27 Aug 2020 19:02:03 +0200 Date: Thu, 27 Aug 2020 19:02:03 +0200 From: Phil Sutter To: Quentin Armitage Cc: netfilter-devel@vger.kernel.org, Florian Westphal Subject: Re: [PATCH] netfilter: nftables: fix documentation for dup statement Message-ID: <20200827170203.GM23632@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Quentin Armitage , netfilter-devel@vger.kernel.org, Florian Westphal References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi, On Thu, Aug 27, 2020 at 04:42:00PM +0100, Quentin Armitage wrote: > The dup statement requires an address, and the device is optional, > not the other way round. > > Signed-off-by: Quentin Armitage > --- > doc/statements.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/statements.txt b/doc/statements.txt > index 9155f286..835db087 100644 > --- a/doc/statements.txt > +++ b/doc/statements.txt > @@ -648,7 +648,7 @@ The dup statement is used to duplicate a packet and send the > copy to a different > destination. > > [verse] > -*dup to* 'device' > +*dup to* 'address' > *dup to* 'address' *device* 'device' > > .Dup statement values The examples are wrong, too. I wonder if this is really just a mistake and all three examples given (including the "advanced" usage using a map) are just wrong or if 'dup' actually was meant to support duplicating to a device in mirror port fashion. Florian, you wrote the docs. What's your take here? Thanks, Phil