netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Balazs Scheidler <bazsi77@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nftables 1/4] socket: add support for "wildcard" key
Date: Fri, 28 Aug 2020 18:20:45 +0200	[thread overview]
Message-ID: <20200828162045.GA29891@salvia> (raw)
In-Reply-To: <20200822062203.3617-2-bazsi77@gmail.com>

Hi Balazs,

One more comment for your upcoming v2 ;-)

On Sat, Aug 22, 2020 at 08:22:00AM +0200, Balazs Scheidler wrote:
[...]
>  src/evaluate.c     | 5 ++++-
>  src/parser_bison.y | 2 ++
>  src/parser_json.c  | 2 ++
>  src/scanner.l      | 1 +
>  src/socket.c       | 6 ++++++
>  5 files changed, 15 insertions(+), 1 deletion(-)

Please, update include/linux/netfilter/nf_tables.h to add
NFT_SOCKET_WILDCARD.

Thanks.

  parent reply	other threads:[~2020-08-28 16:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-22  6:21 [PATCH nftables 0/4] socket: add support for "wildcard" key Balazs Scheidler
2020-08-22  6:22 ` [PATCH nftables 1/4] " Balazs Scheidler
2020-08-22  9:23   ` Stefano Brivio
2020-08-28 16:20   ` Pablo Neira Ayuso [this message]
2020-08-22  6:22 ` [PATCH nftables 2/4] doc: added documentation on "socket wildcard" Balazs Scheidler
2020-08-22  9:17   ` Stefano Brivio
2020-08-22  6:22 ` [PATCH nftables 3/4] tests: added "socked wildcard" testcases Balazs Scheidler
2020-08-22  9:16   ` Stefano Brivio
2020-08-22  6:22 ` [PATCH nftables 4/4] tests: allow tests to use a custom nft executable Balazs Scheidler
2020-08-22  9:15   ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200828162045.GA29891@salvia \
    --to=pablo@netfilter.org \
    --cc=bazsi77@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).