From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next 0/4] netfilter: revisit conntrack statistics
Date: Fri, 28 Aug 2020 19:52:04 +0200 [thread overview]
Message-ID: <20200828175204.GA24446@salvia> (raw)
In-Reply-To: <20200825225245.8072-1-fw@strlen.de>
On Wed, Aug 26, 2020 at 12:52:41AM +0200, Florian Westphal wrote:
> With recent addition of clash resolution the 'insert_failed' counter has
> become confusing. Depending on wheter clash resolution is successful,
> insert_failed increments or both insert_failed and drop increment.
>
> Example (conntrack -S):
> [..] insert_failed=15 drop=0 [..] search_restart=268
>
> This means clash resolution worked and the insert_failed increase is harmeless.
> In case drop is non-zero, things become murky.
>
> It would be better to have a dedicated counter that only increments when
> clash resolution is successful.
>
> This series revisits conntrack statistics. Counters that do not
> indicate an error or reside in fast-paths are removed.
>
> With patched kernel and conntrack tool, output looks similar to this
> during a 'clash resolve' stress test:
>
> [..] insert_failed=9 drop=9 [..] search_restart=123 clash_resolve=3675
Series applied, thanks.
prev parent reply other threads:[~2020-08-28 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 22:52 [PATCH nf-next 0/4] netfilter: revisit conntrack statistics Florian Westphal
2020-08-25 22:52 ` [PATCH nf-next 1/4] netfilter: conntrack: do not increment two error counters at same time Florian Westphal
2020-08-25 22:52 ` [PATCH nf-next 2/4] netfilter: conntrack: remove ignore stats Florian Westphal
2020-08-25 22:52 ` [PATCH nf-next 3/4] netfilter: conntrack: add clash resolution stat counter Florian Westphal
2020-08-25 22:52 ` [PATCH nf-next 4/4] netfilter: conntrack: remove unneeded nf_ct_put Florian Westphal
2020-08-28 17:52 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828175204.GA24446@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).