From: Stefano Brivio <sbrivio@redhat.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Balazs Scheidler <bazsi77@gmail.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nftables v2 5/5] tests: allow tests/monitor to use a custom nft executable
Date: Sat, 29 Aug 2020 14:24:31 +0200 [thread overview]
Message-ID: <20200829142431.19d34600@elisabeth> (raw)
In-Reply-To: <20200829111850.GE9645@salvia>
On Sat, 29 Aug 2020 13:18:50 +0200
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Sat, Aug 29, 2020 at 09:04:05AM +0200, Balazs Scheidler wrote:
> > Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
> > ---
> > tests/monitor/run-tests.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/monitor/run-tests.sh b/tests/monitor/run-tests.sh
> > index ffb833a7..5a736fc6 100755
> > --- a/tests/monitor/run-tests.sh
> > +++ b/tests/monitor/run-tests.sh
> > @@ -1,7 +1,7 @@
> > #!/bin/bash
> >
> > cd $(dirname $0)
> > -nft=../../src/nft
> > +nft=${NFT:-../../src/nft}
> > debug=false
> > test_json=false
>
> IIRC, Stefano mentioned this might break valgrind due to lack of
> quotes?
Wait, this is just for monitor/run-tests.sh now. The problem was on the
change proposed for shell/run_tests.sh, which wasn't needed because
it already supports passing a different command, and is not in this
version.
For monitor/run-tests.sh, I think that will need some fixing anyway (if
we want to support wrappers at all). So this change itself just
improves things.
--
Stefano
next prev parent reply other threads:[~2020-08-29 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 7:04 Balazs Scheidler
2020-08-29 7:04 ` [PATCH nftables v2 1/5] socket: add support for "wildcard" key Balazs Scheidler
2020-08-29 11:17 ` Pablo Neira Ayuso
2020-08-29 7:04 ` [PATCH nftables v2 2/5] src/scanner.l: fix whitespace issue for the TRANSPARENT keyword Balazs Scheidler
2020-08-29 11:17 ` Pablo Neira Ayuso
2020-08-29 7:04 ` [PATCH nftables v2 3/5] doc: added documentation on "socket wildcard" Balazs Scheidler
2020-08-29 11:17 ` Pablo Neira Ayuso
2020-08-29 7:04 ` [PATCH nftables v2 4/5] tests: added "socket wildcard" testcases Balazs Scheidler
2020-08-29 11:17 ` Pablo Neira Ayuso
2020-08-29 7:04 ` [PATCH nftables v2 5/5] tests: allow tests/monitor to use a custom nft executable Balazs Scheidler
2020-08-29 11:18 ` Pablo Neira Ayuso
2020-08-29 12:24 ` Stefano Brivio [this message]
2020-08-29 14:21 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829142431.19d34600@elisabeth \
--to=sbrivio@redhat.com \
--cc=bazsi77@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).