From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 436B3C43461 for ; Tue, 8 Sep 2020 09:56:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E50621D79 for ; Tue, 8 Sep 2020 09:56:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728936AbgIHJ4W (ORCPT ); Tue, 8 Sep 2020 05:56:22 -0400 Received: from correo.us.es ([193.147.175.20]:52734 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728828AbgIHJ4V (ORCPT ); Tue, 8 Sep 2020 05:56:21 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id F2AEDF2598 for ; Tue, 8 Sep 2020 11:56:18 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id DC34BDA84D for ; Tue, 8 Sep 2020 11:56:18 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id C498FDA78F; Tue, 8 Sep 2020 11:56:18 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 9E1D3DA7B6; Tue, 8 Sep 2020 11:56:16 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 08 Sep 2020 11:56:16 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 7D0A64301DE0; Tue, 8 Sep 2020 11:56:16 +0200 (CEST) Date: Tue, 8 Sep 2020 11:56:16 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Martin Willi Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, Florent Fourcot , Romain Bellan Subject: Re: [PATCH nf] netfilter: ctnetlink: fix mark based dump filtering regression Message-ID: <20200908095616.GA3446@salvia> References: <20200901065619.4484-1-martin@strongswan.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200901065619.4484-1-martin@strongswan.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Sep 01, 2020 at 08:56:19AM +0200, Martin Willi wrote: > conntrack mark based dump filtering may falsely skip entries if a mask > is given: If the mask-based check does not filter out the entry, the > else-if check is always true and compares the mark without considering > the mask. The if/else-if logic seems wrong. > > Given that the mask during filter setup is implicitly set to 0xffffffff > if not specified explicitly, the mark filtering flags seem to just > complicate things. Restore the previously used approach by always > matching against a zero mask is no filter mark is given. Applied, thanks.