* Can someone please update libnetfilter_queue online documentation
@ 2020-09-06 0:18 Duncan Roe
2020-09-06 21:49 ` Pablo Neira Ayuso
0 siblings, 1 reply; 6+ messages in thread
From: Duncan Roe @ 2020-09-06 0:18 UTC (permalink / raw)
To: Netfilter Development
Hi everyone,
The online doc for libnetfilter_queue at
https://netfilter.org/projects/libnetfilter_queue/doxygen/html/ is still at
release 1.0.3.
Documentation forms a large part of release 1.0.4 / 1.0.5, so can someone please
build 1.0.5 doc and put it up?
You only need to do './configure --with-doxygen; make' and you have it.
Cheers ... Duncan.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Can someone please update libnetfilter_queue online documentation
2020-09-06 0:18 Can someone please update libnetfilter_queue online documentation Duncan Roe
@ 2020-09-06 21:49 ` Pablo Neira Ayuso
2020-09-07 1:22 ` Duncan Roe
0 siblings, 1 reply; 6+ messages in thread
From: Pablo Neira Ayuso @ 2020-09-06 21:49 UTC (permalink / raw)
To: Netfilter Development
On Sun, Sep 06, 2020 at 10:18:17AM +1000, Duncan Roe wrote:
> Hi everyone,
>
> The online doc for libnetfilter_queue at
> https://netfilter.org/projects/libnetfilter_queue/doxygen/html/ is still at
> release 1.0.3.
Refreshed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Can someone please update libnetfilter_queue online documentation
2020-09-06 21:49 ` Pablo Neira Ayuso
@ 2020-09-07 1:22 ` Duncan Roe
2020-09-07 10:39 ` [PATCH libnetfilter_queue] build: check whether dot is available when configuring doxygen Jeremy Sowden
0 siblings, 1 reply; 6+ messages in thread
From: Duncan Roe @ 2020-09-07 1:22 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Netfilter Development
On Sun, Sep 06, 2020 at 11:49:04PM +0200, Pablo Neira Ayuso wrote:
> On Sun, Sep 06, 2020 at 10:18:17AM +1000, Duncan Roe wrote:
> > Hi everyone,
> >
> > The online doc for libnetfilter_queue at
> > https://netfilter.org/projects/libnetfilter_queue/doxygen/html/ is still at
> > release 1.0.3.
>
> Refreshed.
Thanks, Pablo.
It looks like you don't have the 'graphviz' package installed, so there are
lines like
> Collaboration diagram for User-space network packet buffer:
with no diagram.
(e.g. in
https://netfilter.org/projects/libnetfilter_queue/doxygen/html/group__pktbuff.html).
'graphviz' supplies the 'dot' program which you may have seen doxygen
complaining about. I didn't see the problem originally because I have graphviz
but it didn't come with Slackware so the lack of it may be common.
The fix would be to have config.ac create HAVE_DOT and use that in
doxygen.cfg.in to put YES or NO on the HAVE_DOT and maybe some other lines.
I may tackle that sometime as I gain more confidence with aoutotools.
Cheers ... Duncan.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH libnetfilter_queue] build: check whether dot is available when configuring doxygen.
2020-09-07 1:22 ` Duncan Roe
@ 2020-09-07 10:39 ` Jeremy Sowden
2020-09-08 9:52 ` Duncan Roe
2020-09-08 10:49 ` Pablo Neira Ayuso
0 siblings, 2 replies; 6+ messages in thread
From: Jeremy Sowden @ 2020-09-07 10:39 UTC (permalink / raw)
To: Duncan Roe, Pablo Neira Ayuso; +Cc: Netfilter Devel
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
configure.ac | 4 ++++
doxygen.cfg.in | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index d8d1d387c773..32e499071b26 100644
--- a/configure.ac
+++ b/configure.ac
@@ -41,6 +41,10 @@ AC_ARG_WITH([doxygen], [AS_HELP_STRING([--with-doxygen],
[], [with_doxygen=no])
AS_IF([test "x$with_doxygen" = xyes], [
AC_CHECK_PROGS([DOXYGEN], [doxygen])
+ AC_CHECK_PROGS([DOT], [dot], [""])
+ AS_IF([test "x$DOT" != "x"],
+ [AC_SUBST(HAVE_DOT, YES)],
+ [AC_SUBST(HAVE_DOT, NO)])
])
AM_CONDITIONAL([HAVE_DOXYGEN], [test -n "$DOXYGEN"])
diff --git a/doxygen.cfg.in b/doxygen.cfg.in
index 3f13f97ad8ba..c54f534ada3f 100644
--- a/doxygen.cfg.in
+++ b/doxygen.cfg.in
@@ -161,7 +161,7 @@ PERL_PATH = /usr/bin/perl
CLASS_DIAGRAMS = YES
MSCGEN_PATH =
HIDE_UNDOC_RELATIONS = YES
-HAVE_DOT = YES
+HAVE_DOT = @HAVE_DOT@
CLASS_GRAPH = YES
COLLABORATION_GRAPH = YES
GROUP_GRAPHS = YES
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH libnetfilter_queue] build: check whether dot is available when configuring doxygen.
2020-09-07 10:39 ` [PATCH libnetfilter_queue] build: check whether dot is available when configuring doxygen Jeremy Sowden
@ 2020-09-08 9:52 ` Duncan Roe
2020-09-08 10:49 ` Pablo Neira Ayuso
1 sibling, 0 replies; 6+ messages in thread
From: Duncan Roe @ 2020-09-08 9:52 UTC (permalink / raw)
To: Pablo Neira Ayuso, Netfilter Devel
On Mon, Sep 07, 2020 at 11:39:04AM +0100, Jeremy Sowden wrote:
> Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
> ---
> configure.ac | 4 ++++
> doxygen.cfg.in | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index d8d1d387c773..32e499071b26 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -41,6 +41,10 @@ AC_ARG_WITH([doxygen], [AS_HELP_STRING([--with-doxygen],
> [], [with_doxygen=no])
> AS_IF([test "x$with_doxygen" = xyes], [
> AC_CHECK_PROGS([DOXYGEN], [doxygen])
> + AC_CHECK_PROGS([DOT], [dot], [""])
> + AS_IF([test "x$DOT" != "x"],
> + [AC_SUBST(HAVE_DOT, YES)],
> + [AC_SUBST(HAVE_DOT, NO)])
> ])
>
> AM_CONDITIONAL([HAVE_DOXYGEN], [test -n "$DOXYGEN"])
> diff --git a/doxygen.cfg.in b/doxygen.cfg.in
> index 3f13f97ad8ba..c54f534ada3f 100644
> --- a/doxygen.cfg.in
> +++ b/doxygen.cfg.in
> @@ -161,7 +161,7 @@ PERL_PATH = /usr/bin/perl
> CLASS_DIAGRAMS = YES
> MSCGEN_PATH =
> HIDE_UNDOC_RELATIONS = YES
> -HAVE_DOT = YES
> +HAVE_DOT = @HAVE_DOT@
> CLASS_GRAPH = YES
> COLLABORATION_GRAPH = YES
> GROUP_GRAPHS = YES
> --
> 2.28.0
>
Tested-by: Duncan Roe <duncan_roe@optusnet.com.au>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH libnetfilter_queue] build: check whether dot is available when configuring doxygen.
2020-09-07 10:39 ` [PATCH libnetfilter_queue] build: check whether dot is available when configuring doxygen Jeremy Sowden
2020-09-08 9:52 ` Duncan Roe
@ 2020-09-08 10:49 ` Pablo Neira Ayuso
1 sibling, 0 replies; 6+ messages in thread
From: Pablo Neira Ayuso @ 2020-09-08 10:49 UTC (permalink / raw)
To: Jeremy Sowden; +Cc: Duncan Roe, Netfilter Devel
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-08 10:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-06 0:18 Can someone please update libnetfilter_queue online documentation Duncan Roe
2020-09-06 21:49 ` Pablo Neira Ayuso
2020-09-07 1:22 ` Duncan Roe
2020-09-07 10:39 ` [PATCH libnetfilter_queue] build: check whether dot is available when configuring doxygen Jeremy Sowden
2020-09-08 9:52 ` Duncan Roe
2020-09-08 10:49 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).