From: Pablo Neira Ayuso <pablo@netfilter.org>
To: 20200921234912.GA6657@salvia.int
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 nf-next] netfilter: nf_tables: add userdata attributes to nft_chain
Date: Wed, 23 Sep 2020 13:20:07 +0200 [thread overview]
Message-ID: <20200923112007.GA3218@salvia> (raw)
In-Reply-To: <20200923105517.1480-1-guigom@riseup.net>
On Wed, Sep 23, 2020 at 12:55:17PM +0200, Jose M. Guisado Gomez wrote:
> @@ -2079,15 +2098,21 @@ static int nf_tables_addchain(struct nft_ctx *ctx, u8 family, u8 genmask,
> err = nft_chain_add(table, chain);
> if (err < 0) {
> nft_trans_destroy(trans);
> - goto err2;
> + goto err_chain_add;
> }
>
> table->use++;
>
> return 0;
> -err2:
> +err_chain_add:
> +err_trans:
I suggest to replace these two tags by:
err_unregister_hook:
> nf_tables_unregister_hook(net, table, chain);
> -err1:
> +err_register_hook:
> +err_alloc_rules:
and these two above by:
err_free_udata:
> + kfree(chain->udata);
> +err_userdata:
> +err_chain_name:
> +err_flag:
and these three by:
err_destroy_chain:
> nf_tables_chain_destroy(ctx);
>
> return err;
Thanks.
next prev parent reply other threads:[~2020-09-23 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 10:55 [PATCH v2 nf-next] netfilter: nf_tables: add userdata attributes to nft_chain Jose M. Guisado Gomez
2020-09-23 11:20 ` Pablo Neira Ayuso [this message]
2020-09-23 11:20 ` Pablo Neira Ayuso
2020-09-23 13:16 ` [PATCH v3 " Jose M. Guisado Gomez
2020-09-23 13:30 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923112007.GA3218@salvia \
--to=pablo@netfilter.org \
--cc=20200921234912.GA6657@salvia.int \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).