From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D3C9C2D0A8 for ; Wed, 23 Sep 2020 11:20:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 039F9205F4 for ; Wed, 23 Sep 2020 11:20:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726466AbgIWLUL (ORCPT ); Wed, 23 Sep 2020 07:20:11 -0400 Received: from correo.us.es ([193.147.175.20]:38872 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726422AbgIWLUL (ORCPT ); Wed, 23 Sep 2020 07:20:11 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 0CC89DA3CD for ; Wed, 23 Sep 2020 13:20:10 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id F1ADFDA73D for ; Wed, 23 Sep 2020 13:20:09 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id E75F5DA704; Wed, 23 Sep 2020 13:20:09 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id B94F1DA73D; Wed, 23 Sep 2020 13:20:07 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 23 Sep 2020 13:20:07 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 9EBBD4301DE0; Wed, 23 Sep 2020 13:20:07 +0200 (CEST) Date: Wed, 23 Sep 2020 13:20:07 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: 20200921234912.GA6657@salvia.int Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH v2 nf-next] netfilter: nf_tables: add userdata attributes to nft_chain Message-ID: <20200923112007.GA3218@salvia> References: <20200923105517.1480-1-guigom@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200923105517.1480-1-guigom@riseup.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Sep 23, 2020 at 12:55:17PM +0200, Jose M. Guisado Gomez wrote: > @@ -2079,15 +2098,21 @@ static int nf_tables_addchain(struct nft_ctx *ctx, u8 family, u8 genmask, > err = nft_chain_add(table, chain); > if (err < 0) { > nft_trans_destroy(trans); > - goto err2; > + goto err_chain_add; > } > > table->use++; > > return 0; > -err2: > +err_chain_add: > +err_trans: I suggest to replace these two tags by: err_unregister_hook: > nf_tables_unregister_hook(net, table, chain); > -err1: > +err_register_hook: > +err_alloc_rules: and these two above by: err_free_udata: > + kfree(chain->udata); > +err_userdata: > +err_chain_name: > +err_flag: and these three by: err_destroy_chain: > nf_tables_chain_destroy(ctx); > > return err; Thanks.