From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E526C4727E for ; Wed, 30 Sep 2020 12:26:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06EEB2071E for ; Wed, 30 Sep 2020 12:26:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729742AbgI3M0Q (ORCPT ); Wed, 30 Sep 2020 08:26:16 -0400 Received: from correo.us.es ([193.147.175.20]:42686 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727997AbgI3M0Q (ORCPT ); Wed, 30 Sep 2020 08:26:16 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id D0ACA2EFEB0 for ; Wed, 30 Sep 2020 14:26:14 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C134BDA850 for ; Wed, 30 Sep 2020 14:26:14 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id BFE8ADA84F; Wed, 30 Sep 2020 14:26:14 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 52D91DA84D; Wed, 30 Sep 2020 14:26:12 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 30 Sep 2020 14:26:12 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 351F642EF9E1; Wed, 30 Sep 2020 14:26:12 +0200 (CEST) Date: Wed, 30 Sep 2020 14:26:11 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Florian Westphal Cc: Arturo Borrero Gonzalez , Phil Sutter , "netfilter-devel@vger.kernel.org" Subject: Re: iptables-nft-restore issue Message-ID: <20200930122453.GA24863@salvia> References: <198c69b7-d7b2-f910-c469-199bfe2fda28@netfilter.org> <20200930115922.GC20140@breakpoint.cc> <20200930121314.GA21983@salvia> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="6sX45UoQRIJXqkqR" Content-Disposition: inline In-Reply-To: <20200930121314.GA21983@salvia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org --6sX45UoQRIJXqkqR Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Wed, Sep 30, 2020 at 02:13:14PM +0200, Pablo Neira Ayuso wrote: > On Wed, Sep 30, 2020 at 01:59:22PM +0200, Florian Westphal wrote: > > Arturo Borrero Gonzalez wrote: > > > Hi Phil, > > > > > > (CC'ing netfilter-devel) > > > > > > I discovered my openstack neutron linuxbridge-agent malfunctioning when using > > > iptables-nft and it seems this ruleset is causing the issue: > > > > > === 8< === > > > *raw > > > :OUTPUT - [0:0] > > > :PREROUTING - [0:0] > > If I replace these two by: > > :OUTPUT ACCEPT [0:0] > :PREROUTING ACCEPT [0:0] > > it works. Looks like some issue with the basechain policy? Probably this patch? > > > :neutron-linuxbri-OUTPUT - [0:0] > > > :neutron-linuxbri-PREROUTING - [0:0] > > > -I OUTPUT 1 -j neutron-linuxbri-OUTPUT > > > -I PREROUTING 1 -j neutron-linuxbri-PREROUTING > > > -I neutron-linuxbri-PREROUTING 1 -m physdev --physdev-in brq7425e328-56 -m > > > comment --comment "Set zone for f101a28-1d" -j CT --zone 4097 > > > -I neutron-linuxbri-PREROUTING 2 -i brq7425e328-56 -m comment --comment "Set > > > zone for f101a28-1d" -j CT --zone 4097 > > > -I neutron-linuxbri-PREROUTING 3 -m physdev --physdev-in tap7f101a28-1d -m > > > comment --comment "Set zone for f101a28-1d" -j CT --zone 4097 > > > > > > COMMIT --6sX45UoQRIJXqkqR Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="x.patch" diff --git a/iptables/nft.c b/iptables/nft.c index 27bb98d184c7..f29fe5b47575 100644 --- a/iptables/nft.c +++ b/iptables/nft.c @@ -678,7 +678,9 @@ nft_chain_builtin_alloc(const struct builtin_table *table, nftnl_chain_set_str(c, NFTNL_CHAIN_NAME, chain->name); nftnl_chain_set_u32(c, NFTNL_CHAIN_HOOKNUM, chain->hook); nftnl_chain_set_u32(c, NFTNL_CHAIN_PRIO, chain->prio); - nftnl_chain_set_u32(c, NFTNL_CHAIN_POLICY, policy); + if (policy >= 0) + nftnl_chain_set_u32(c, NFTNL_CHAIN_POLICY, policy); + nftnl_chain_set_str(c, NFTNL_CHAIN_TYPE, chain->type); return c; @@ -911,6 +913,8 @@ int nft_chain_set(struct nft_handle *h, const char *table, c = nft_chain_new(h, table, chain, NF_DROP, counters); else if (strcmp(policy, "ACCEPT") == 0) c = nft_chain_new(h, table, chain, NF_ACCEPT, counters); + else if (strcmp(policy, "-") == 0) + c = nft_chain_new(h, table, chain, -1, counters); else errno = EINVAL; --6sX45UoQRIJXqkqR--