From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org,
Serhey Popovych <serhe.popovych@gmail.com>
Subject: Re: [iptables PATCH 3/3] libxtables: Register multiple extensions in ascending order
Date: Tue, 6 Oct 2020 11:29:55 +0200 [thread overview]
Message-ID: <20201006092955.GK29050@orbyte.nwl.cc> (raw)
In-Reply-To: <20201005234121.GA14242@salvia>
On Tue, Oct 06, 2020 at 01:41:21AM +0200, Pablo Neira Ayuso wrote:
> On Wed, Sep 23, 2020 at 12:53:41AM +0200, Phil Sutter wrote:
> > The newly introduced ordered insert algorithm in
> > xtables_register_{match,target}() works best if extensions of same name
> > are passed in ascending revisions. Since this is the case in about all
> > extensions' arrays, iterate over them from beginning to end.
>
> This patch should come first in the series, my understanding is that
> 1/3 assumes that extensions are registered from lower to higher
> revision number.
No, the algorithm is supposed to work with arbitrary input. This is
merely an optimization given how extension arrays are typically ordered.
Cheers, Phil
next prev parent reply other threads:[~2020-10-06 9:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 22:53 [iptables PATCH 0/3] libxtables: Fix for pointless socket() calls Phil Sutter
2020-09-22 22:53 ` [iptables PATCH 1/3] libxtables: Make sure extensions register in revision order Phil Sutter
2020-10-03 11:17 ` Pablo Neira Ayuso
2020-10-04 14:53 ` Phil Sutter
2020-10-05 22:42 ` Pablo Neira Ayuso
2020-10-06 9:27 ` Phil Sutter
2020-10-06 9:50 ` Pablo Neira Ayuso
2020-10-06 10:13 ` Phil Sutter
2020-10-06 10:48 ` Pablo Neira Ayuso
2020-10-06 12:07 ` [iptables PATCH v2] " Phil Sutter
2020-10-06 23:59 ` Pablo Neira Ayuso
2020-09-22 22:53 ` [iptables PATCH 2/3] libxtables: Simplify pending extension registration Phil Sutter
2020-10-05 23:08 ` Pablo Neira Ayuso
2020-09-22 22:53 ` [iptables PATCH 3/3] libxtables: Register multiple extensions in ascending order Phil Sutter
2020-10-05 23:41 ` Pablo Neira Ayuso
2020-10-06 9:29 ` Phil Sutter [this message]
2020-09-23 11:45 ` [iptables PATCH 0/3] libxtables: Fix for pointless socket() calls Pablo Neira Ayuso
2020-09-23 14:30 ` Phil Sutter
2020-10-07 0:02 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006092955.GK29050@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=serhe.popovych@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).