From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org,
Laura Garcia Liebana <nevola@gmail.com>
Subject: Re: [iptables PATCH] extensions: libipt_icmp: Fix translation of type 'any'
Date: Tue, 6 Oct 2020 20:52:22 +0200 [thread overview]
Message-ID: <20201006185222.GH5213@breakpoint.cc> (raw)
In-Reply-To: <20201006171301.6192-1-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> By itself, '-m icmp --icmp-type any' is a noop, it matches any icmp
> types. Yet nft_ipv4_xlate() does not emit an 'ip protocol' match if
> there's an extension with same name present in the rule. Luckily, legacy
> iptables demands icmp match to be prepended by '-p icmp', so we can
> assume this is present and just emit the 'ip protocol' match from icmp
> xlate callback.
Reviewed-by: Florian Westphal <fw@strlen.de>
prev parent reply other threads:[~2020-10-06 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 17:13 [iptables PATCH] extensions: libipt_icmp: Fix translation of type 'any' Phil Sutter
2020-10-06 18:52 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006185222.GH5213@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=nevola@gmail.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).