From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B824CC41604 for ; Tue, 6 Oct 2020 18:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6653E206B5 for ; Tue, 6 Oct 2020 18:52:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726894AbgJFSwZ (ORCPT ); Tue, 6 Oct 2020 14:52:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726760AbgJFSwZ (ORCPT ); Tue, 6 Oct 2020 14:52:25 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF9F0C061755 for ; Tue, 6 Oct 2020 11:52:24 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1kPs4U-00077S-Jp; Tue, 06 Oct 2020 20:52:22 +0200 Date: Tue, 6 Oct 2020 20:52:22 +0200 From: Florian Westphal To: Phil Sutter Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org, Laura Garcia Liebana Subject: Re: [iptables PATCH] extensions: libipt_icmp: Fix translation of type 'any' Message-ID: <20201006185222.GH5213@breakpoint.cc> References: <20201006171301.6192-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201006171301.6192-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > By itself, '-m icmp --icmp-type any' is a noop, it matches any icmp > types. Yet nft_ipv4_xlate() does not emit an 'ip protocol' match if > there's an extension with same name present in the rule. Luckily, legacy > iptables demands icmp match to be prepended by '-p icmp', so we can > assume this is present and just emit the 'ip protocol' match from icmp > xlate callback. Reviewed-by: Florian Westphal