From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 713C9C433E7 for ; Thu, 8 Oct 2020 17:32:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D0B022200 for ; Thu, 8 Oct 2020 17:32:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729377AbgJHRcA (ORCPT ); Thu, 8 Oct 2020 13:32:00 -0400 Received: from correo.us.es ([193.147.175.20]:39150 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729179AbgJHRcA (ORCPT ); Thu, 8 Oct 2020 13:32:00 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 1DE1718CDC3 for ; Thu, 8 Oct 2020 19:31:59 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 0E5AEDA791 for ; Thu, 8 Oct 2020 19:31:59 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 03E72DA73F; Thu, 8 Oct 2020 19:31:59 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id BBD95DA73F; Thu, 8 Oct 2020 19:31:56 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 08 Oct 2020 19:31:56 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 9F7D542EF4E0; Thu, 8 Oct 2020 19:31:56 +0200 (CEST) Date: Thu, 8 Oct 2020 19:31:56 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Arturo Borrero Gonzalez Cc: netfilter-devel@vger.kernel.org, phil@nwl.cc Subject: Re: [iptables PATCH] iptables-nft: fix basechain policy configuration Message-ID: <20201008173156.GA14654@salvia> References: <160163907669.18523.7311010971070291883.stgit@endurance> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <160163907669.18523.7311010971070291883.stgit@endurance> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Fri, Oct 02, 2020 at 01:44:36PM +0200, Arturo Borrero Gonzalez wrote: > From: Pablo Neira Ayuso > > Previous to this patch, the basechain policy could not be properly configured if it wasn't > explictly set when loading the ruleset, leading to iptables-nft-restore (and ip6tables-nft-restore) > trying to send an invalid ruleset to the kernel. I have applied this with some amendments to the test file to cover the --noflush case. I think this is a real problem there, where you can combine to apply incremental updates to the ruleset. For the --flush case, I still have doubts how to use this feature, not sure it is worth the effort to actually fix it. We can revisit later, you can rewrite this later Phil.