* [PATCH] netfilter: nf_conntrack_sip: Fix inconsistent of format with argument type in nf_nat_sip.
@ 2020-10-09 7:03 Ye Bin
2020-10-20 15:17 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Ye Bin @ 2020-10-09 7:03 UTC (permalink / raw)
To: pablo, kadlec, fw, netfilter-devel, coreteam; +Cc: Ye Bin
Fix follow warning:
[net/netfilter/nf_nat_sip.c:469]: (warning) %u in format string (no. 1)
requires 'unsigned int' but the argument type is 'int'.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
net/netfilter/nf_nat_sip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_nat_sip.c b/net/netfilter/nf_nat_sip.c
index f0a735e86851..39754fb3a298 100644
--- a/net/netfilter/nf_nat_sip.c
+++ b/net/netfilter/nf_nat_sip.c
@@ -466,7 +466,7 @@ static int mangle_content_len(struct sk_buff *skb, unsigned int protoff,
&matchoff, &matchlen) <= 0)
return 0;
- buflen = sprintf(buffer, "%u", c_len);
+ buflen = sprintf(buffer, "%d", c_len);
return mangle_packet(skb, protoff, dataoff, dptr, datalen,
matchoff, matchlen, buffer, buflen);
}
--
2.16.2.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netfilter: nf_conntrack_sip: Fix inconsistent of format with argument type in nf_nat_sip.
2020-10-09 7:03 [PATCH] netfilter: nf_conntrack_sip: Fix inconsistent of format with argument type in nf_nat_sip Ye Bin
@ 2020-10-20 15:17 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2020-10-20 15:17 UTC (permalink / raw)
To: Ye Bin; +Cc: kadlec, fw, netfilter-devel, coreteam
On Fri, Oct 09, 2020 at 03:03:35PM +0800, Ye Bin wrote:
> Fix follow warning:
> [net/netfilter/nf_nat_sip.c:469]: (warning) %u in format string (no. 1)
> requires 'unsigned int' but the argument type is 'int'.
Yes, but mangle_packet() takes unsigned int as buflen.
This needs a bit wider look that, I'm afraid, a robot cannot afford.
Thanks for submitting your patch in any case.
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
> net/netfilter/nf_nat_sip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/nf_nat_sip.c b/net/netfilter/nf_nat_sip.c
> index f0a735e86851..39754fb3a298 100644
> --- a/net/netfilter/nf_nat_sip.c
> +++ b/net/netfilter/nf_nat_sip.c
> @@ -466,7 +466,7 @@ static int mangle_content_len(struct sk_buff *skb, unsigned int protoff,
> &matchoff, &matchlen) <= 0)
> return 0;
>
> - buflen = sprintf(buffer, "%u", c_len);
> + buflen = sprintf(buffer, "%d", c_len);
> return mangle_packet(skb, protoff, dataoff, dptr, datalen,
> matchoff, matchlen, buffer, buflen);
> }
> --
> 2.16.2.dirty
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-20 15:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-09 7:03 [PATCH] netfilter: nf_conntrack_sip: Fix inconsistent of format with argument type in nf_nat_sip Ye Bin
2020-10-20 15:17 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).