From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Francesco Ruggeri <fruggeri@arista.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
kuba@kernel.org, davem@davemloft.net, fw@strlen.org,
kadlec@netfilter.org
Subject: Re: [PATCH nf v2] netfilter: conntrack: connection timeout after re-register
Date: Tue, 20 Oct 2020 17:21:35 +0200 [thread overview]
Message-ID: <20201020152135.GA19913@salvia> (raw)
In-Reply-To: <20201007193252.7009D95C169C@us180.sjc.aristanetworks.com>
On Wed, Oct 07, 2020 at 12:32:52PM -0700, Francesco Ruggeri wrote:
> If the first packet conntrack sees after a re-register is an outgoing
> keepalive packet with no data (SEG.SEQ = SND.NXT-1), td_end is set to
> SND.NXT-1.
> When the peer correctly acknowledges SND.NXT, tcp_in_window fails
> check III (Upper bound for valid (s)ack: sack <= receiver.td_end) and
> returns false, which cascades into nf_conntrack_in setting
> skb->_nfct = 0 and in later conntrack iptables rules not matching.
> In cases where iptables are dropping packets that do not match
> conntrack rules this can result in idle tcp connections to time out.
Applied, thanks.
prev parent reply other threads:[~2020-10-20 15:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 19:32 [PATCH nf v2] netfilter: conntrack: connection timeout after re-register Francesco Ruggeri
2020-10-08 23:41 ` Francesco Ruggeri
2020-10-09 6:52 ` Jozsef Kadlecsik
2020-10-09 11:03 ` Florian Westphal
2020-10-09 18:48 ` Jozsef Kadlecsik
2020-10-09 18:55 ` Florian Westphal
2020-10-09 19:49 ` Jozsef Kadlecsik
2020-10-09 20:00 ` Francesco Ruggeri
2020-10-09 20:05 ` Florian Westphal
2020-10-14 0:06 ` Pablo Neira Ayuso
2020-10-14 8:11 ` Pablo Neira Ayuso
2020-10-14 8:23 ` Florian Westphal
2020-10-14 18:42 ` Francesco Ruggeri
2020-10-14 19:35 ` Florian Westphal
2020-10-20 15:21 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020152135.GA19913@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fruggeri@arista.com \
--cc=fw@strlen.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).