From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Mikhail Sennikovsky <mikhail.sennikovskii@cloud.ionos.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] conntrack: implement save output format
Date: Mon, 2 Nov 2020 14:49:10 +0100 [thread overview]
Message-ID: <20201102134910.GA11998@salvia> (raw)
In-Reply-To: <20201029115156.69784-2-mikhail.sennikovskii@cloud.ionos.com>
On Thu, Oct 29, 2020 at 12:51:55PM +0100, Mikhail Sennikovsky wrote:
> This commit allows dumping conntrack entries in the format
> used by the conntrack parameters, aka "save" output format.
> This is useful for saving ct entry data to allow applying
> it later on.
>
> To enable the "save" output the "-o save" parameter needs
> to be passed to the contnrack tool invocation.
Applied, thanks.
A few minor glitches, the most relevant to mention is that -u UNSET is
displayed when the status bits string is empty.
I have also added a check to allow for -o save only, maybe some other
output flags can be supported in combination in the future, meanwhile,
let's report an error to the user.
Thanks.
next prev parent reply other threads:[~2020-11-02 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 11:51 [PATCH v2 0/2] conntrack: save output format Mikhail Sennikovsky
2020-10-29 11:51 ` [PATCH v2 1/2] conntrack: implement " Mikhail Sennikovsky
2020-11-02 13:49 ` Pablo Neira Ayuso [this message]
2020-10-29 11:51 ` [PATCH v2 2/2] conntrack.8: man update for opts format support Mikhail Sennikovsky
2020-11-02 13:49 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102134910.GA11998@salvia \
--to=pablo@netfilter.org \
--cc=mikhail.sennikovskii@cloud.ionos.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).