From: Florian Westphal <fw@strlen.de>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 1/7] parser: merge sack-perm/sack-permitted and maxseg/mss
Date: Thu, 5 Nov 2020 16:45:09 +0100 [thread overview]
Message-ID: <20201105154509.GA25824@breakpoint.cc> (raw)
In-Reply-To: <20201105152256.GA3399@azazel.net>
Jeremy Sowden <jeremy@azazel.net> wrote:
> > - | MAXSEG { $$ = TCPOPTHDR_MAXSEG; }
> > + | MSS { $$ = TCPOPTHDR_MAXSEG; }
> > + | SACK_PERM { $$ = TCPOPTHDR_SACK_PERMITTED; }
> > | WINDOW { $$ = TCPOPTHDR_WINDOW; }
> > - | SACK_PERMITTED { $$ = TCPOPTHDR_SACK_PERMITTED; }
> > + | WSCALE { $$ = TCPOPTHDR_WINDOW; }
>
> Did you mean to add this here?
Right, this could be a distinct change.
ATM there is
... synproxy ... wscale
and
... tcp option window ...
Like the sack-perm vs. sack-permitted mess it probably
makes sense to get rid of one of those tokens so both work
interchangeably, i.e.
tcp option wscale
and
tcp option window
are the same.
I will remove this chunk before pushing it out.
next prev parent reply other threads:[~2020-11-05 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 14:11 [PATCH nft 0/7] rework tcp option handling Florian Westphal
2020-11-05 14:11 ` [PATCH nft 1/7] parser: merge sack-perm/sack-permitted and maxseg/mss Florian Westphal
2020-11-05 15:22 ` Jeremy Sowden
2020-11-05 15:45 ` Florian Westphal [this message]
2020-11-05 14:11 ` [PATCH nft 2/7] tcpopts: clean up parser -> tcpopt.c plumbing Florian Westphal
2020-11-05 14:11 ` [PATCH nft 3/7] tcpopt: rename noop to nop Florian Westphal
2020-11-05 14:11 ` [PATCH nft 4/7] tcpopt: split tcpopt_hdr_fields into per-option enum Florian Westphal
2020-11-05 14:11 ` [PATCH nft 5/7] tcpopt: allow to check for presence of any tcp option Florian Westphal
2020-11-05 19:11 ` Jeremy Sowden
2020-11-05 20:57 ` Jeremy Sowden
2020-11-09 11:10 ` Florian Westphal
2020-11-09 11:38 ` Jeremy Sowden
2020-11-05 14:11 ` [PATCH nft 6/7] tcp: add raw tcp option match support Florian Westphal
2020-11-05 14:11 ` [PATCH nft 7/7] json: " Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105154509.GA25824@breakpoint.cc \
--to=fw@strlen.de \
--cc=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).