[PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement

[PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement

[Randy Dunlap]

Fix build errors in net/bridge/netfilter/nft_reject_bridge.ko
by selecting NF_REJECT_IPV4, which provides the missing symbols.

ERROR: modpost: "nf_reject_skb_v4_tcp_reset" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
ERROR: modpost: "nf_reject_skb_v4_unreach" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!

Fixes: fa538f7cf05a ("netfilter: nf_reject: add reject skbuff creation helpers")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: kernel test robot <lkp@intel.com>
Cc: Jose M. Guisado Gomez <guigom@riseup.net>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Cc: coreteam@netfilter.org
Cc: Jakub Kicinski <kuba@kernel.org>
---
 net/bridge/netfilter/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20201113.orig/net/bridge/netfilter/Kconfig
+++ linux-next-20201113/net/bridge/netfilter/Kconfig
@@ -18,6 +18,7 @@ config NFT_BRIDGE_META
 config NFT_BRIDGE_REJECT
 	tristate "Netfilter nf_tables bridge reject support"
 	depends on NFT_REJECT
+	depends on NF_REJECT_IPV4
 	help
 	  Add support to reject packets.
 

Re: [PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement

[Pablo Neira Ayuso]

Hi,

Thanks for catching up this.

On Sun, Nov 15, 2020 at 07:42:03PM -0800, Randy Dunlap wrote:
> Fix build errors in net/bridge/netfilter/nft_reject_bridge.ko
> by selecting NF_REJECT_IPV4, which provides the missing symbols.
> 
> ERROR: modpost: "nf_reject_skb_v4_tcp_reset" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
> ERROR: modpost: "nf_reject_skb_v4_unreach" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
> 
> Fixes: fa538f7cf05a ("netfilter: nf_reject: add reject skbuff creation helpers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: kernel test robot <lkp@intel.com>
> Cc: Jose M. Guisado Gomez <guigom@riseup.net>
> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
> Cc: Florian Westphal <fw@strlen.de>
> Cc: netfilter-devel@vger.kernel.org
> Cc: coreteam@netfilter.org
> Cc: Jakub Kicinski <kuba@kernel.org>
> ---
>  net/bridge/netfilter/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20201113.orig/net/bridge/netfilter/Kconfig
> +++ linux-next-20201113/net/bridge/netfilter/Kconfig
> @@ -18,6 +18,7 @@ config NFT_BRIDGE_META
>  config NFT_BRIDGE_REJECT
>  	tristate "Netfilter nf_tables bridge reject support"
>  	depends on NFT_REJECT
> +	depends on NF_REJECT_IPV4

I can update the patch here before applying to add:

        depends on NF_REJECT_IPV6

as well. It seems both dependencies (IPv4 and IPv6) are missing.

Thanks.

>  	help
>  	  Add support to reject packets.
>  

Re: [PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement

[Randy Dunlap]

On 11/16/20 1:26 AM, Pablo Neira Ayuso wrote:
> Hi,
> 
> Thanks for catching up this.
> 
> On Sun, Nov 15, 2020 at 07:42:03PM -0800, Randy Dunlap wrote:
>> Fix build errors in net/bridge/netfilter/nft_reject_bridge.ko
>> by selecting NF_REJECT_IPV4, which provides the missing symbols.
>>
>> ERROR: modpost: "nf_reject_skb_v4_tcp_reset" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
>> ERROR: modpost: "nf_reject_skb_v4_unreach" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
>>
>> Fixes: fa538f7cf05a ("netfilter: nf_reject: add reject skbuff creation helpers")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: kernel test robot <lkp@intel.com>
>> Cc: Jose M. Guisado Gomez <guigom@riseup.net>
>> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
>> Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
>> Cc: Florian Westphal <fw@strlen.de>
>> Cc: netfilter-devel@vger.kernel.org
>> Cc: coreteam@netfilter.org
>> Cc: Jakub Kicinski <kuba@kernel.org>
>> ---
>>  net/bridge/netfilter/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- linux-next-20201113.orig/net/bridge/netfilter/Kconfig
>> +++ linux-next-20201113/net/bridge/netfilter/Kconfig
>> @@ -18,6 +18,7 @@ config NFT_BRIDGE_META
>>  config NFT_BRIDGE_REJECT
>>  	tristate "Netfilter nf_tables bridge reject support"
>>  	depends on NFT_REJECT
>> +	depends on NF_REJECT_IPV4
> 
> I can update the patch here before applying to add:
> 
>         depends on NF_REJECT_IPV6
> 
> as well. It seems both dependencies (IPv4 and IPv6) are missing.
> 
> Thanks.
> 
>>  	help
>>  	  Add support to reject packets.
>>  

Yes, that's good.

Thanks.

-- 
~Randy