From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Georg Kohmann <geokohma@cisco.com>
Cc: netdev@vger.kernel.org, kadlec@netfilter.org, fw@strlen.de,
davem@davemloft.net, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, kuba@kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH net v4] ipv6/netfilter: Discard first fragment not including all headers
Date: Wed, 18 Nov 2020 19:16:55 +0100 [thread overview]
Message-ID: <20201118181655.GA11119@salvia> (raw)
In-Reply-To: <20201111115025.28879-1-geokohma@cisco.com>
Hi,
On Wed, Nov 11, 2020 at 12:50:25PM +0100, Georg Kohmann wrote:
[...]
> diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c
> index c8cf1bb..e3869ba 100644
> --- a/net/ipv6/reassembly.c
> +++ b/net/ipv6/reassembly.c
> @@ -318,15 +318,43 @@ static int ip6_frag_reasm(struct frag_queue *fq, struct sk_buff *skb,
> return -1;
> }
>
> +/* Check if the upper layer header is truncated in the first fragment. */
> +bool ipv6_frag_thdr_truncated(struct sk_buff *skb, int start, u8 *nexthdrp)
Please, follow up and send a patch to place this function in
include/net/ipv6_frag.h as static inline.
See: https://marc.info/?l=netfilter-devel&m=160571942728516&w=2
next prev parent reply other threads:[~2020-11-18 18:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 11:50 [PATCH net v4] ipv6/netfilter: Discard first fragment not including all headers Georg Kohmann
2020-11-14 18:57 ` Jakub Kicinski
2020-11-15 11:15 ` Pablo Neira Ayuso
2020-11-16 18:16 ` Jakub Kicinski
2020-11-18 18:16 ` Pablo Neira Ayuso [this message]
2020-11-18 22:57 ` Georg Kohmann (geokohma)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118181655.GA11119@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=geokohma@cisco.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).