From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org,
razor@blackwall.org, tobias@waldekranz.com, jeremy@azazel.net
Subject: [PATCH net-next,v4 5/9] bridge: resolve forwarding path for bridge devices
Date: Wed, 18 Nov 2020 23:30:07 +0100 [thread overview]
Message-ID: <20201118223011.3216-6-pablo@netfilter.org> (raw)
In-Reply-To: <20201118223011.3216-1-pablo@netfilter.org>
Add .ndo_fill_forward_path for bridge devices.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
v4: - Check for valid bridge dst pointer after READ_ONCE, per Nikolay
Aleksandrov.
include/linux/netdevice.h | 1 +
net/bridge/br_device.c | 27 +++++++++++++++++++++++++++
2 files changed, 28 insertions(+)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index e9690e1a6559..281551c70536 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -836,6 +836,7 @@ typedef u16 (*select_queue_fallback_t)(struct net_device *dev,
enum net_device_path_type {
DEV_PATH_ETHERNET = 0,
DEV_PATH_VLAN,
+ DEV_PATH_BRIDGE,
};
struct net_device_path {
diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
index 387403931a63..ce03d82e384a 100644
--- a/net/bridge/br_device.c
+++ b/net/bridge/br_device.c
@@ -391,6 +391,32 @@ static int br_del_slave(struct net_device *dev, struct net_device *slave_dev)
return br_del_if(br, slave_dev);
}
+static int br_fill_forward_path(struct net_device_path_ctx *ctx,
+ struct net_device_path *path)
+{
+ struct net_bridge_fdb_entry *f;
+ struct net_bridge_port *dst;
+ struct net_bridge *br;
+
+ if (netif_is_bridge_port(ctx->dev))
+ return -1;
+
+ br = netdev_priv(ctx->dev);
+ f = br_fdb_find_rcu(br, ctx->daddr, 0);
+ if (!f || !f->dst)
+ return -1;
+
+ dst = READ_ONCE(f->dst);
+ if (!dst)
+ return -1;
+
+ path->type = DEV_PATH_BRIDGE;
+ path->dev = dst->br->dev;
+ ctx->dev = dst->dev;
+
+ return 0;
+}
+
static const struct ethtool_ops br_ethtool_ops = {
.get_drvinfo = br_getinfo,
.get_link = ethtool_op_get_link,
@@ -425,6 +451,7 @@ static const struct net_device_ops br_netdev_ops = {
.ndo_bridge_setlink = br_setlink,
.ndo_bridge_dellink = br_dellink,
.ndo_features_check = passthru_features_check,
+ .ndo_fill_forward_path = br_fill_forward_path,
};
static struct device_type br_type = {
--
2.20.1
next prev parent reply other threads:[~2020-11-18 22:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 22:30 [PATCH net-next,v4 0/9] netfilter: flowtable bridge and vlan enhancements Pablo Neira Ayuso
2020-11-18 22:30 ` [PATCH net-next,v4 1/9] netfilter: flowtable: add hash offset field to tuple Pablo Neira Ayuso
2020-11-18 22:30 ` [PATCH net-next,v4 2/9] netfilter: flowtable: add xmit path types Pablo Neira Ayuso
2020-11-18 23:36 ` Florian Westphal
2020-11-18 22:30 ` [PATCH net-next,v4 3/9] net: resolve forwarding path from virtual netdevice and HW destination address Pablo Neira Ayuso
2020-11-18 23:22 ` Florian Westphal
2020-11-18 22:30 ` [PATCH net-next,v4 4/9] net: 8021q: resolve forwarding path for vlan devices Pablo Neira Ayuso
2020-11-18 22:30 ` Pablo Neira Ayuso [this message]
2020-11-18 22:30 ` [PATCH net-next,v4 6/9] netfilter: flowtable: use dev_fill_forward_path() to obtain ingress device Pablo Neira Ayuso
2020-11-18 22:30 ` [PATCH net-next,v4 7/9] netfilter: flowtable: use dev_fill_forward_path() to obtain egress device Pablo Neira Ayuso
2020-11-18 22:30 ` [PATCH net-next,v4 8/9] netfilter: flowtable: add vlan support Pablo Neira Ayuso
2020-11-18 22:30 ` [PATCH net-next,v4 9/9] selftests: netfilter: flowtable bridge and VLAN support Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118223011.3216-6-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=jeremy@azazel.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).