netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
	netdev@vger.kernel.org, kuba@kernel.org, razor@blackwall.org,
	tobias@waldekranz.com, jeremy@azazel.net
Subject: Re: [PATCH net-next,v4 2/9] netfilter: flowtable: add xmit path types
Date: Thu, 19 Nov 2020 00:36:15 +0100	[thread overview]
Message-ID: <20201118233615.GD15137@breakpoint.cc> (raw)
In-Reply-To: <20201118223011.3216-3-pablo@netfilter.org>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> -	if (unlikely(dst_xfrm(&rt->dst))) {
> +	rt = (struct rtable *)tuplehash->tuple.dst_cache;
> +
> +	if (unlikely(tuplehash->tuple.xmit_type == FLOW_OFFLOAD_XMIT_XFRM)) {
>  		memset(skb->cb, 0, sizeof(struct inet_skb_parm));
>  		IPCB(skb)->iif = skb->dev->ifindex;
>  		IPCB(skb)->flags = IPSKB_FORWARDED;
>  		return nf_flow_xmit_xfrm(skb, state, &rt->dst);
>  	}
[..]

> +
> +	if (unlikely(tuplehash->tuple.xmit_type == FLOW_OFFLOAD_XMIT_NEIGH))

This needs to be XMIT_XFRM too.

  reply	other threads:[~2020-11-18 23:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18 22:30 [PATCH net-next,v4 0/9] netfilter: flowtable bridge and vlan enhancements Pablo Neira Ayuso
2020-11-18 22:30 ` [PATCH net-next,v4 1/9] netfilter: flowtable: add hash offset field to tuple Pablo Neira Ayuso
2020-11-18 22:30 ` [PATCH net-next,v4 2/9] netfilter: flowtable: add xmit path types Pablo Neira Ayuso
2020-11-18 23:36   ` Florian Westphal [this message]
2020-11-18 22:30 ` [PATCH net-next,v4 3/9] net: resolve forwarding path from virtual netdevice and HW destination address Pablo Neira Ayuso
2020-11-18 23:22   ` Florian Westphal
2020-11-18 22:30 ` [PATCH net-next,v4 4/9] net: 8021q: resolve forwarding path for vlan devices Pablo Neira Ayuso
2020-11-18 22:30 ` [PATCH net-next,v4 5/9] bridge: resolve forwarding path for bridge devices Pablo Neira Ayuso
2020-11-18 22:30 ` [PATCH net-next,v4 6/9] netfilter: flowtable: use dev_fill_forward_path() to obtain ingress device Pablo Neira Ayuso
2020-11-18 22:30 ` [PATCH net-next,v4 7/9] netfilter: flowtable: use dev_fill_forward_path() to obtain egress device Pablo Neira Ayuso
2020-11-18 22:30 ` [PATCH net-next,v4 8/9] netfilter: flowtable: add vlan support Pablo Neira Ayuso
2020-11-18 22:30 ` [PATCH net-next,v4 9/9] selftests: netfilter: flowtable bridge and VLAN support Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201118233615.GD15137@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=davem@davemloft.net \
    --cc=jeremy@azazel.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=razor@blackwall.org \
    --cc=tobias@waldekranz.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).