From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org,
Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH nf] netfilter: nf_tables: avoid false-postive lockdep splat
Date: Fri, 20 Nov 2020 13:54:31 +0100 [thread overview]
Message-ID: <20201120125431.GA32383@salvia> (raw)
In-Reply-To: <20201119153454.28089-1-fw@strlen.de>
On Thu, Nov 19, 2020 at 04:34:54PM +0100, Florian Westphal wrote:
> There are reports wrt lockdep splat in nftables, e.g.:
> ------------[ cut here ]------------
> WARNING: CPU: 2 PID: 31416 at net/netfilter/nf_tables_api.c:622
> lockdep_nfnl_nft_mutex_not_held+0x28/0x38 [nf_tables]
> ...
>
> These are caused by an earlier, unrelated bug such as a n ABBA deadlock
> in a different subsystem.
> In such an event, lockdep is disabled and lockdep_is_held returns true
> unconditionally. This then causes the WARN() in nf_tables.
>
> Make the WARN conditional on lockdep still active to avoid this.
Applied, thanks.
prev parent reply other threads:[~2020-11-20 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 15:34 [PATCH nf] netfilter: nf_tables: avoid false-postive lockdep splat Florian Westphal
2020-11-20 12:54 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120125431.GA32383@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=naresh.kamboju@linaro.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox